Skip to content

FIX: Update the bootstrap config #831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Dec 4, 2020
Merged

FIX: Update the bootstrap config #831

merged 9 commits into from
Dec 4, 2020

Conversation

aakoshh
Copy link
Contributor

@aakoshh aakoshh commented Dec 3, 2020 •
edited
Loading

Description

Updated the etc and mordor bootstrap node configuration based on core-geth. Also added @KonradStaniec's node.

It turns out that what we had configured for etc were the Ethereum mainnet nodes. Replacing with the ones dedicated for Ethereum Classic may speed up discovery as well.

@aakoshh aakoshh changed the title Fix bootstrap config FIX: Update the bootstrap config Dec 3, 2020
@aakoshh aakoshh force-pushed the fix-bootstrap-config branch from 0d6900a to 3fb801b Compare December 3, 2020 17:44
@aakoshh
Copy link
Contributor Author

aakoshh commented Dec 3, 2020

I don't know if it might cause problems but if we get the port wrong, the peer manager blacklists the peer's IP for 30 minutes, so even if discovery figures out later what the correct port is, it may take a long time until the same node is tried again. This only affects the bootstraps/known-nodes, the others' ports come form the ENR.

@aakoshh aakoshh force-pushed the fix-bootstrap-config branch from 3fb801b to 847f3ad Compare December 3, 2020 17:53
@aakoshh aakoshh force-pushed the fix-bootstrap-config branch from f6954fc to ad876c6 Compare December 3, 2020 18:41
ntallar
ntallar requested changes Dec 3, 2020
View reviewed changes
Copy link

@ntallar ntallar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fast sync to etc mainnet took 8 minutes to start!

(I wasn't able to take a look at the random lookup fix yet)

src/main/resources/chains/etc-chain.conf Outdated
"enode://70b74fef51aa4f36330cc52ac04f16d38e1838f531f58bbc88365ca5fd4a3da6e8ec32316c43f79b157d0575faf53064fd925644d0f620b2b201b028c2b410d0@47.115.150.90:30303", //ETC Labs
"enode://fa64d1fcb2d4cd1d1606cb940ea2b69fee7dc6c7a85ac4ad05154df1e9ae9616a6a0fa67a59cb15f79346408efa5a4efeba1e5993ddbf4b5cedbda27644a61cf@47.91.30.48:30303", //ETC Labs

"enode://a7219ff608bdca40174d005610f80a8d216aa9695e34542d27d69cfd6bf5478fd3b5c83c08ad537a06425cce9cda975571053dcb174d44f109b7362d26798256@18.159.208.198:53818", // IOHK ec2-18-159-208-198.eu-central-1.compute.amazonaws.com
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't seem to be able to connect to this instace

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I tried with the default ports, 18.159.208.198:30303 then 18.159.208.198:9072?discport=30303 but those didn't work, I was hoping this might as it's from etcnodes.org

@KonradStaniec do you know what might be wrong?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Konrad is off today... I'd maybe remove this and re-add it once we speak with him about how he has it configured

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. He said he asked devops about firewalls and port forwarding etc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

@aakoshh aakoshh force-pushed the fix-bootstrap-config branch from e91dbb1 to 9c84341 Compare December 3, 2020 23:41
ntallar
ntallar reviewed Dec 4, 2020
View reviewed changes
Copy link

@ntallar ntallar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from my comments answers, LGTM!

@ntallar ntallar added the high priority This PRs should be reviewed and merged ASAP label Dec 4, 2020
ntallar
ntallar approved these changes Dec 4, 2020
View reviewed changes
Copy link

@ntallar ntallar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

 .\\            //.
. \ \          / /.
.\  ,\     /` /,.-
 -.   \  /'/ /  .
 ` -   `-'  \  -
   '.       /.\`
      -    .-
      :`//.'
      .`.'
      .' BP

@ntallar ntallar merged commit 06b53b8 into develop Dec 4, 2020
@ntallar ntallar deleted the fix-bootstrap-config branch December 4, 2020 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntallar ntallar ntallar approved these changes

@KonradStaniec KonradStaniec Awaiting requested review from KonradStaniec

@jmendiola222 jmendiola222 Awaiting requested review from jmendiola222

Assignees
No one assigned
Labels
high priority This PRs should be reviewed and merged ASAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aakoshh @ntallar