[FIX] Empty address handling #844
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kapke
reviewed
Dec 8, 2020
| @@ -94,15 +94,15 @@ trait JsonMethodsImplicits { | |||
|
|
|||
| for { | |||
| from <- input.get("from") match { | |||
| case Some(JString(s)) => extractAddress(s) | |||
| case Some(JString(s)) if s.nonEmpty => extractAddress(s) | |||
| case Some(JString(_)) => extractAddress("0x0") | |||
There was a problem hiding this comment.
that line is invalid I think, no one should be able to send tx from "0x0" address
mmrozek
force-pushed
the
fix/empty-address-handling
branch
from
6f74777 to
72841fd
Compare
biandratti
approved these changes
Dec 9, 2020
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Empty string should not be validated as the correct address