[ETCM-454] Migrate Scala Futures to Monix Tasks #855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aakoshh
reviewed
Dec 11, 2020
src/ets/scala/io/iohk/ethereum/ets/blockchain/BlockchainSuite.scala
Outdated
Show resolved
Hide resolved
aakoshh
reviewed
Dec 11, 2020
src/main/scala/io/iohk/ethereum/blockchain/sync/regular/BlockImporter.scala
Outdated
Show resolved
Hide resolved
aakoshh
reviewed
Dec 11, 2020
| @@ -110,7 +110,7 @@ class BlockImport( | |||
| block: Block, | |||
| currentBestBlock: Block, | |||
| currentWeight: ChainWeight | |||
| )(implicit blockExecutionContext: ExecutionContext): Future[BlockImportResult] = Future { | |||
| )(implicit blockExecutionContext: ExecutionContext): Task[BlockImportResult] = Task.evalOnce { | |||
There was a problem hiding this comment.
Why is this evalOnce, or the ones above, needed? Isn't the task only evaluated once?
There was a problem hiding this comment.
I thought the same. But some tests fail if I just use Task.eval, precisely because the mock expectations only expect 1 call. I would like to understand why in the tests this code is evaluated more than once, but this is the best I found for now.
aakoshh
reviewed
Dec 11, 2020
src/main/scala/io/iohk/ethereum/blockchain/sync/regular/BlockImporter.scala
Outdated
Show resolved
Hide resolved
aakoshh
reviewed
Dec 11, 2020
src/main/scala/io/iohk/ethereum/blockchain/sync/regular/BlockImporter.scala
Outdated
Show resolved
Hide resolved
aakoshh
reviewed
Dec 11, 2020
src/test/scala/io/iohk/ethereum/blockchain/sync/regular/RegularSyncSpec.scala
Outdated
Show resolved
Hide resolved
aakoshh
reviewed
Dec 11, 2020
src/test/scala/io/iohk/ethereum/blockchain/sync/regular/RegularSyncSpec.scala
Outdated
Show resolved
Hide resolved
aakoshh
reviewed
Dec 11, 2020
src/test/scala/io/iohk/ethereum/blockchain/sync/regular/RegularSyncSpec.scala
Outdated
Show resolved
Hide resolved
aakoshh
reviewed
Dec 11, 2020
src/test/scala/io/iohk/ethereum/consensus/BlockGeneratorSpec.scala
Outdated
Show resolved
Hide resolved
lemastero
suggested changes
Dec 15, 2020
src/main/scala/io/iohk/ethereum/consensus/ethash/EthashBlockCreator.scala
Show resolved
Hide resolved
lemastero
reviewed
Dec 15, 2020
lemastero
reviewed
Dec 15, 2020
src/main/scala/io/iohk/ethereum/consensus/ethash/EthashConsensus.scala
Outdated
Show resolved
Hide resolved
lemastero
reviewed
Dec 15, 2020
src/main/scala/io/iohk/ethereum/consensus/ethash/TransactionPicker.scala
Outdated
Show resolved
Hide resolved
lemastero
reviewed
Dec 15, 2020
lemastero
reviewed
Dec 15, 2020
lemastero
reviewed
Dec 15, 2020
src/main/scala/io/iohk/ethereum/mallet/service/RpcClientMallet.scala
Outdated
Show resolved
Hide resolved
lemastero
reviewed
Dec 15, 2020
lemastero
reviewed
Dec 15, 2020
src/test/scala/io/iohk/ethereum/blockchain/sync/FastSyncSpec.scala
Outdated
Show resolved
Hide resolved
lemastero
reviewed
Dec 16, 2020
src/main/scala/io/iohk/ethereum/blockchain/sync/regular/BlockFetcher.scala
Show resolved
Hide resolved
lemastero
approved these changes
Dec 16, 2020
aakoshh
approved these changes
Dec 17, 2020
biandratti
reviewed
Dec 17, 2020
src/main/scala/io/iohk/ethereum/blockchain/sync/regular/BlockImporter.scala
Show resolved
Hide resolved
biandratti
reviewed
Dec 17, 2020
biandratti
reviewed
Dec 17, 2020
biandratti
approved these changes
Dec 17, 2020
|
LGTM! |
lemastero
changed the title
lemastero
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changing a bunch of usages of Scala's
Futureto MonixTask.Proposed Solution
Trying to keep everything in Monix
Tasksand only convert toFutureto execute them in the "edges" of the application.Important Changes Introduced
Testing