[CHORE] Add encrypt-key command to CLI #858
Conversation
| private val EncryptKey: Command[String] = | ||
| Command(name = encryptKeyCommand, header = "Encrypt private key") { | ||
|
|
||
| val privateKey = Opts |
There was a problem hiding this comment.
Shouldn't common options be defined outside commands? Or maybe even all options should replace current string constants in lines ~17-25?
There was a problem hiding this comment.
I prefer to leave string constants because it is convenient to use them in tests
| ByteStringUtils.hash2string(decrypted) shouldBe privateKey | ||
| } | ||
|
|
||
| it should "encrypt private key (with passphrase)" in { |
There was a problem hiding this comment.
minor: this test looks like a perfect candidate for a property-based one.
There was a problem hiding this comment.
Not really. I don't want to test decryption/encryption here. It should be done in a different place. I only want to check if I get the correct JSON when I specify the correct arguments
README.md
Outdated
| @@ -50,6 +50,11 @@ Possible networks: `etc`, `eth`, `mordor`, `testnet-internal` | |||
| ./bin/mantis cli generate-key-pairs 5 | |||
| ``` | |||
|
|
|||
| - encrypt private key (could be used to setup private faucet) | |||
There was a problem hiding this comment.
Probably bit more documentation (and explanation) would be helpful. Either here or in the help for that command
Description
encrypt-keycommand could be useful to set up a faucet