Skip to content

ETCM-530 Add a setup for Besu and Geth that allows to evaluate their performance #914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 3, 2021

Conversation

leo-bogastry
Copy link
Contributor

Description

Add a setup for Besu and Geth that allows to evaluate their performance.

Proposed Solution

Similarly to what is already available for Mantis, a docker setup was added for Besu and Geth where metrics are exposed and a basic Grafana dashboard is available.
More metrics can be explored and added to Grafana dashboards later.

Testing

Run each provided script

Copy link
Contributor

@robinraju robinraju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, verified it locally.

Copy link
Contributor

@jvdp jvdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tried it locally but it looks good to my eyeballs 👍

Have you considered having one docker-compose.yml so you can share grafana and prometheus and run subsets as required? Or everything when doing a comparative benchmark.

@leo-bogastry
Copy link
Contributor Author

Haven't tried it locally but it looks good to my eyeballs 👍

Have you considered having one docker-compose.yml so you can share grafana and prometheus and run subsets as required? Or everything when doing a comparative benchmark.

I understand your point of view, but that sounds messy actually, having more than one ETC client running on our machines and competing for resources, it would be more far from a real scenario

@leo-bogastry leo-bogastry force-pushed the feature/ETCM-530-besu-geth-baselline branch from 4cc21e1 to 929b7c4 Compare February 3, 2021 13:27
@leo-bogastry
Copy link
Contributor Author

Rebased

@jvdp
Copy link
Contributor

jvdp commented Feb 3, 2021

I understand your point of view, but that sounds messy actually, having more than one ETC client running on our machines and competing for resources, it would be more far from a real scenario

Ah yeah that makes sense, they'd only get in eachother's way.

@leo-bogastry leo-bogastry merged commit 4a68bae into develop Feb 3, 2021
@leo-bogastry leo-bogastry deleted the feature/ETCM-530-besu-geth-baselline branch February 3, 2021 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants