ETCM-541 attempt UPnP port mapping to aid in peer discovery & connection #929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
February 22, 2021 21:03
jvdp
requested review from
1015bit,
aakoshh,
bsuieric,
AnastasiiaL and
leo-bogastry
![pullrequest[bot]](https://avatars.githubusercontent.com/in/3434?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ This pull request was sent to the PullRequest network.
@jvdp you can click here to see the review status or cancel the code review job - or - cancel by adding [!pr] to the title of the pull request.
| @@ -47,6 +47,9 @@ mantis { | |||
| port = 9076 | |||
| } | |||
|
|
|||
| # Try automatic port forwarding via UPnP | |||
| automatic-port-forwarding = true | |||
There was a problem hiding this comment.
Should this be on by default?
There was a problem hiding this comment.
For it to be useful, I think so. Someone who wouldn't map the ports themselves probably won't be inclined to enable this manually either, right?
aakoshh
reviewed
Feb 23, 2021
src/main/scala/io/iohk/ethereum/network/discovery/DiscoveryServiceBuilder.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
This looks nice and clean overall. I didn't see any issues beyond what was already pointed out.
Reviewed with ❤️ by PullRequest
aakoshh
reviewed
Feb 24, 2021
aakoshh
reviewed
Feb 24, 2021
aakoshh
approved these changes
Feb 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this addition Mantis will try to use UPnP to open an UDP port for Kademlia / peer discovery and a TCP port for the Ethereum protocol. Can be disabled via
mantis.network.automatic-port-forwarding = false(defaults to true.)