ETS integration RPC endpoints #966
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grale88
force-pushed
the
feature/ETCM-697-retesteth-endpoints
branch
from
2c8c3ad to
c3ce44b
Compare
…pment, also simplifies dist mapping a bit
Signed-off-by: Igor Grahovac <[email protected]>
…cording to eth spec for retesteth. Fixed genesis loading for regular node
…null fields in JSON response, add coinbase field to BlockResponse
…nature fields required by retesteth
…d storing of contract codes and storage data
dzajkowski
force-pushed
the
feature/ETCM-697-retesteth-endpoints
branch
from
2b7537d to
9dcde25
Compare
dzajkowski
reviewed
Apr 21, 2021
| { case jv => deserializeUint256String(jv) }, | ||
| PartialFunction.empty | ||
| ) | ||
| ) |
There was a problem hiding this comment.
formatting seems off here
dzajkowski
reviewed
Apr 22, 2021
| @@ -74,6 +76,7 @@ trait JsonRpcBaseController { | |||
| JsonRpcControllerMetrics.recordMethodTime(request.method, time) | |||
| } | |||
| } | |||
| .flatTap { response => Task { log.debug(s"sending response ${response.inspect}") } } | |||
There was a problem hiding this comment.
note: find out why there's no tap
dzajkowski
reviewed
Apr 22, 2021
| .fold(number => blockchain.getBlockByNumber(number), hash => blockchain.getBlockByHash(hash)) | ||
|
|
||
| if (blockOpt.isEmpty) { | ||
| Task.now(Right(AccountsInRangeResponse(Map(), ByteString(0)))) |
There was a problem hiding this comment.
@jvdp do you know why this task is here? am I missing a side-effect?
There was a problem hiding this comment.
This has to be a bug and should be returned, I'm pretty sure. It would make the .gets below safe.
dzajkowski
approved these changes
Apr 22, 2021
jvdp
reviewed
Apr 23, 2021
| @@ -164,7 +164,7 @@ class TestService( | |||
| accountAddresses = genesisData.alloc.keys.toList | |||
| accountRangeOffset = 0 | |||
|
|
|||
| Task.now(Right(SetChainParamsResponse())) | |||
| SetChainParamsResponse().rightNow | |||
There was a problem hiding this comment.
Being unfamiliar to this I find this worse, somehow... but it's purely subjective.
There was a problem hiding this comment.
Also, I'm kinda surprised that the core RPC methods aren't overloaded for 'bare' (non-Task) responses. Should be possible, right?
jvdp
approved these changes
Apr 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Initial integration of ETS (Ethereum tests) executed through Retesteth test suite.
Proposed Solution
Some of existing endpoints were updated according to newer changes in the runner and the tests. Additional methods were added, such as test_importRawBlock, test_getLogHash, debug_accountRangeAt and debug_storageRangeAt. Follow up tasks/bugs are created in order to ensure further progress and fixes for the tests that are failing.
Modifications were made to standard eth RPC responses because of Mantis custom fields that are avalable only when "testmode" is configured.