Use nix instead of json in output of hackage-to-nix #118
Conversation
|
|
||
| -- Avoid issues with case insensitive file systems by escaping upper case | ||
| -- characters with a leading _ character. | ||
| escapeUpperCase :: String -> String |
There was a problem hiding this comment.
This sounds a bit like a custom hack to me … what about just add something like a base64 representation of strings we want to encode?
There was a problem hiding this comment.
As this is for filenames, base64 encoding would make it a lot less readable :-/
I wonder if we'd run into camelCase issues.
That would be converted into camel_case, and thus clash with a package named camel_case? Can we rule out that this would happen?
There was a problem hiding this comment.
I wanted the file names to still be human readable. I guess we could include both human and base64 encoding, but then it is kind of a custom format again.
There was a problem hiding this comment.
My hot take would be that here we had a good opportunity to hide this hack behind an abstraction, meaning a small lib. This is a micro Haskell project I would be glad to publish on Hackage!
|
|
||
| -- Avoid issues with case insensitive file systems by escaping upper case | ||
| -- characters with a leading _ character. | ||
| escapeUpperCase :: String -> String |
There was a problem hiding this comment.
As this is for filenames, base64 encoding would make it a lot less readable :-/
I wonder if we'd run into camelCase issues.
That would be converted into camel_case, and thus clash with a package named camel_case? Can we rule out that this would happen?
It replaces |
We have been using `readFile` and `fromJSON` to read a `.json` a 60MB .json file. This change puts the information contained in the json file into `.nix` files that are imported when needed (rather than all at once). This seems to save around 1s at eval time.
Tested with:
```
time nix-instantiate -E '(import ./. {}).pkgs-unstable.haskell-nix.tool "ghc8107" "hello" {}'
time nix-instantiate -E '(import ./. {}).pkgs-unstable.haskell-nix.tool "ghc8107" "haskell-language-server" {}'
```
See also input-output-hk/nix-tools#118
We have been using
readFileandfromJSONto read a.jsona 60MB .json file. This change puts the information contained in the json file into.nixfiles that are imported when needed (rather than all at once). This seems to save around 1s at eval time.Tested with:
See also input-output-hk/haskell.nix#1574