stack-to-nix: Allow custom output filenames #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roughly dividing up the code into modules. No attempts are made to clean anything up.
angerman
reviewed
Feb 12, 2019
| return $ fromString pkg $= mkPath False nix | ||
|
|
||
| cacheFile :: FilePath | ||
| cacheFile = ".stack-to-nix.cache" | ||
| defaultNixContents :: String |
There was a problem hiding this comment.
No hnix usage to generate the ast? Should we just have a tmpl data folder, and copy the default template from there?
There was a problem hiding this comment.
Yeah I think hnix will be the best way to generate it. String is just for the draft version.
rvl
changed the title
|
Happy to merge this as is (for the refactoring), and do the TODO next week. |
rvl
changed the title
rvl
added a commit
to input-output-hk/haskell.nix
that referenced
this pull request
Feb 26, 2019
It changed in input-output-hk/nix-tools#29. Closes #72
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stack-to-nixcloser tostack2nix, and makes it easier to use.default.nix.Main.hsinto multiple files so that it's slightly easier to follow.TODO:
default.nixwithhnixhaskell.nixin the generated code.stack2nixproduces a single file on stdout. It should be possible to provide such an output mode forstack-to-nix.