Skip to content

Fix build and import haskell.nix override #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2019
Merged

Fix build and import haskell.nix override #44

merged 1 commit into from
Mar 20, 2019

Conversation

rvl
Copy link
Contributor

@rvl rvl commented Mar 19, 2019

There was still some breakage due to overlay → extras. The haskell.nix revision needed to be updated.

I removed the overrideWith because it's not necessary here. The haskell lib can be overridden with normal function args.

@rvl
Fix build and import haskell.nix override
7538d51 
There was still some breakage due to overlay -> extras.
The haskell.nix revision needed to be updated.

I removed the overrideWith because it's not necessary here. The
haskell lib can be overridden with normal function args.
@rvl rvl added the bug Something isn't working label Mar 19, 2019
@rvl rvl self-assigned this Mar 19, 2019
@rvl rvl requested a review from angerman March 19, 2019 22:28
This was referenced Mar 19, 2019
Merged
Merged
angerman
angerman approved these changes Mar 20, 2019
View reviewed changes
Copy link
Collaborator

@angerman angerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm generally ok with this.

I do wonder however if we don't want to retain the -I haskell override, and if we want to use .json files similar to how we use them in all the other repos for consistency?

@rvl
Copy link
Contributor Author

rvl commented Mar 20, 2019

Use this instead:

nix-build --arg haskellLibSrc /path/to/haskell.nix

@rvl rvl merged commit 38bf6fd into master Mar 20, 2019
@rvl rvl deleted the rvl/fix-build branch March 20, 2019 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angerman angerman angerman approved these changes

Assignees

@rvl rvl

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rvl @angerman