Skip to content

Commit 2a9aae2

Browse files
committed
mirage/crates: Fix error handling for GET /api/v1/crates/:id/:version/authors request handler
1 parent 6d2edcb commit 2a9aae2

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

mirage/route-handlers/crates.js

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,9 +65,14 @@ export function register(server) {
6565
});
6666

6767
server.get('/api/v1/crates/:crate_id/:version_num/authors', (schema, request) => {
68-
let crate = request.params.crate_id;
68+
let crateId = request.params.crate_id;
69+
let crate = schema.crates.find(crateId);
70+
if (!crate) return notFound();
71+
6972
let num = request.params.version_num;
70-
let version = schema.versions.findBy({ crate, num });
73+
let version = schema.versions.findBy({ crate: crateId, num });
74+
if (!version) return { errors: [{ detail: `crate \`${crateId}\` does not have a version \`${num}\`` }] };
75+
7176
return { meta: { names: version._authors }, users: [] };
7277
});
7378

0 commit comments

Comments
 (0)