scripts: support local check for developers #113
Conversation
scripts/tidy.sh
Outdated
| fi ; | ||
| done | ||
|
|
||
| wget https://raw.githubusercontent.com/llvm/llvm-project/main/clang-tools-extra/clang-tidy/tool/run-clang-tidy.py -O run-clang-tidy.py |
There was a problem hiding this comment.
@Menooker
I'm not sure it is ok to place code from llvm in our public repository
There was a problem hiding this comment.
@kurapov-peter @ZhennanQin What do you think if we copy .clang-tidy to our repo?
There was a problem hiding this comment.
Do not download if already exists:
[ -f run-clang-tidy.py ] || wget ...
[ -f .clang-tidy ] || wget ... 
There was a problem hiding this comment.
@kurapov-peter @ZhennanQin What do you think if we copy
.clang-tidyto our repo?
sure, @leshikus please take a look
scripts/tidy.sh
Outdated
| done | ||
|
|
||
| wget https://raw.githubusercontent.com/llvm/llvm-project/main/clang-tools-extra/clang-tidy/tool/run-clang-tidy.py -O run-clang-tidy.py | ||
| wget https://raw.githubusercontent.com/llvm/llvm-project/main/mlir/.clang-tidy -O .clang-tidy |
There was a problem hiding this comment.
maybe we can copy this file to our repo? Just like .clang_format?
scripts/tidy.sh
Outdated
| fi ; | ||
| done | ||
|
|
||
| wget https://raw.githubusercontent.com/llvm/llvm-project/main/clang-tools-extra/clang-tidy/tool/run-clang-tidy.py -O run-clang-tidy.py |
There was a problem hiding this comment.
Do not download if already exists:
[ -f run-clang-tidy.py ] || wget ...
[ -f .clang-tidy ] || wget ... 
WangJialei-A
force-pushed
the
wangjial/local_tidy
branch
from
0312f51 to
5674ca0
Compare
WangJialei-A
changed the title
WangJialei-A
force-pushed
the
wangjial/local_tidy
branch
from
5674ca0 to
9ff54ca
Compare
WangJialei-A
force-pushed
the
wangjial/local_tidy
branch
from
9ff54ca to
04275ba
Compare
scripts/full_check.sh
Outdated
|
|
||
| for f in $(find ./include -name Makefile); do | ||
| targets=$(make -f $f help |grep IncGen); | ||
| if [[ $? -eq 0 ]]; then |
There was a problem hiding this comment.
| if [[ $? -eq 0 ]]; then |
There was a problem hiding this comment.
bash if command checks the command exit code by default, the code above is like the check if mybool == true
please use either if cmd or cmd && some_command
| @@ -0,0 +1,111 @@ | |||
| #! /bin/bash | |||
There was a problem hiding this comment.
| #! /bin/bash | |
| #! /bin/bash | |
| set -e |
There was a problem hiding this comment.
It's usually better to use explicit set -e in case someone uses bash script to launch the script
There was a problem hiding this comment.
What about set -e? I think, it's very useful for error checking.
scripts/full_check.sh
Outdated
| -DLLVM_EXTERNAL_LIT=$(which lit) | ||
|
|
||
| for f in $(find ./include -name Makefile); do | ||
| targets=$(make -f $f help |grep IncGen); |
There was a problem hiding this comment.
| targets=$(make -f $f help |grep IncGen); | |
| if targets=$(make -f $f help |grep IncGen); then |
support #20