[tests] Re-enable unittesting and partial fix for the existing errors #249
Conversation
Menooker
requested review from
AndreyPavlenko,
kurapov-peter,
crazydemo,
zhczhong and
ZhennanQin
|
Thank you @Menooker ! |
| check_cxx_compiler_flag("-Wno-unused-but-set-parameter" CXX_SUPPORTS_WNO_UNUSED_BUT_SET_PARAMETER) | ||
| append_if(CXX_SUPPORTS_WNO_UNUSED_BUT_SET_PARAMETER "-Wno-unused-but-set-parameter" CMAKE_CXX_FLAGS) | ||
| if(CXX_SUPPORTS_WNO_UNUSED_BUT_SET_PARAMETER) |
There was a problem hiding this comment.
These lines originally occur after including LLVM cmake, so we don't need to include them by ourselves. A recent refactor swaps the location of these lines with include(LLVM...), so it breaks cmake when g++ < 10.0
| @@ -62,7 +62,7 @@ dlti.target_system_spec = #dlti.target_system_spec< | |||
| >} {} | |||
| )mlir"; | |||
|
|
|||
| TEST(TargetDescriptionAnalysis, CPUMissingValue) { | |||
| TEST(DISABLED_TargetDescriptionAnalysis, CPUMissingValue) { | |||
There was a problem hiding this comment.
We need to re-enable this UT after it is fixed.
There was a problem hiding this comment.
Please add a TODO/FIXME for future reminder
|
So this will fix the escape of unittest from CI/CD, right? |
Yes. It will! |
| if "TMP" in os.environ: | ||
| config.environment["TMP"] = os.environ["TMP"] | ||
| if "TEMP" in os.environ: | ||
| config.environment["TEMP"] = os.environ["TEMP"] | ||
|
|
||
| # Propagate HOME as it can be used to override incorrect homedir in passwd | ||
| # that causes the tests to fail. | ||
| if "HOME" in os.environ: | ||
| config.environment["HOME"] = os.environ["HOME"] |
There was a problem hiding this comment.
nit: seems we can also put these into var list below？
| @@ -128,7 +128,7 @@ void populateCPURuntimePasses(mlir::OpPassManager &pm) { | |||
| pm.addPass(createForallToParallelLoopPass()); | |||
| pm.addPass(createParallelLoopFusionPass()); | |||
| pm.addPass(createLoopInvariantCodeMotionPass()); | |||
| pm.addPass(createConvertMemRefToCPURuntime()); | |||
| pm.addNestedPass<func::FuncOp>(createConvertMemRefToCPURuntime()); | |||
There was a problem hiding this comment.
can we merge this now? bench tool has an issue for some mlir, and it needs this change.
The unit-testing is accidentally disabled since the last refactoring of the
testfolder. We need to add a dummy folder to holdlig.cfg.pyfor the C++ based unit tests.This reveals 2 errors in the current repo.
TargetDescriptionAnalysis.CPUMissingValue(need to fix in a follow-up PR @zhczhong )Also fixed an error which breaks g++9, when we need a workaround on the CXX_FLAGS.