Skip to content

Reuse code, fix Coverity scans #334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 11, 2024
Merged

Reuse code, fix Coverity scans #334

merged 4 commits into from
Sep 11, 2024

Conversation

kwasd
Copy link
Contributor

@kwasd kwasd commented Sep 10, 2024 •
edited
Loading

This fixes Coverity scans and unifies CI code.

@kwasd kwasd marked this pull request as ready for review September 10, 2024 15:34
@kwasd kwasd marked this pull request as draft September 10, 2024 16:07
@kwasd kwasd marked this pull request as ready for review September 10, 2024 17:27
leshikus
leshikus approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@leshikus leshikus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend using script instead of actions, in this way developers can use the same env locally

@kwasd
Copy link
Contributor Author

kwasd commented Sep 10, 2024

I recommend using script instead of actions, in this way developers can use the same env locally

Will implement in a separate PR

@lmontigny lmontigny merged commit be1bcb9 into main Sep 11, 2024
7 checks passed
@lmontigny lmontigny added bug Something isn't working ci Continuous integration and automation labels Sep 11, 2024
@lmontigny lmontigny added this to the 0.3 CI/CD milestone Sep 11, 2024
@kwasd kwasd deleted the fix/coverity branch September 11, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leshikus leshikus leshikus approved these changes

@kurapov-peter kurapov-peter kurapov-peter approved these changes

@AndreyPavlenko AndreyPavlenko Awaiting requested review from AndreyPavlenko

Assignees

@kwasd kwasd

Labels
bug Something isn't working ci Continuous integration and automation
Projects
None yet
Milestone
0.3 CI/CD
Development

Successfully merging this pull request may close these issues.
4 participants
@kwasd @leshikus @kurapov-peter @lmontigny