-
Notifications
You must be signed in to change notification settings - Fork 17
Add no-unused-but-set-parameter to skip verbose warning #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add no-unused-but-set-parameter to skip verbose warning #36
Conversation
@Menooker, is it for MLIR build? If so, I'd suggest we set the flag for the target only and use stricter rules for our code. |
Yes, it is for MLIR only. I have updated the code to let the CXX flag only affect on MLIR targets only. |
39321c1
to
17a532e
Compare
…ijie/no-unused-but-set-parameter
…ijie/no-unused-but-set-parameter
…m/Menooker/graph-compiler into yijie/no-unused-but-set-parameter
# cases, by marking SelectedCase as used. See | ||
# https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85827 for details. The issue is | ||
# fixed in GCC 10. | ||
if(CMAKE_CXX_COMPILER_ID MATCHES "GNU" AND CMAKE_CXX_COMPILER_VERSION VERSION_LESS "10.0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The lines are copied from MLIR upstream. They have the same issue too.
I received the following warning messages many times while compiling. g++ version 9.4.0
This PR disables the warnings for non-MSVC builds.