[GPU] Automatically dump lowered mlir module on 'enableObjectDump=true' #366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: dchigarev <[email protected]>
dchigarev
commented
Oct 2, 2024
Comment on lines
+811
to
+814
| if (enableObjectDump) { | ||
| mod.dump(); | ||
| } | ||
|
|
There was a problem hiding this comment.
@AndreyPavlenko what do you think, should it be a separate option in OclModuleBuilderOptions? Or maybe we can add a bool parameter to OclModuleBuilder::build(..., bool dump_lowered_module=false)?
There was a problem hiding this comment.
It should be a separate option, because enableObjectDump is used to dump the compiled object.
It could also be implemented without adding a new option, like here -
|
decided to implement this in #362 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mlir::ExecutionEngine(enableObjectDump=true)doesn't actually dump any module, but provides an ability to callExecutionEngine::dumpToObjectFile(...)later (which only can dump to a file, while we want it to be dumped to std::err in OV integration).