Implement a version getter for the graph compiler #40
Conversation
|
Just a proposal - what about using a single number versioning, without major, minor... etc? It much more easy to use the single number versions in the code, especially in macros. I don't see any benefits from the 3num versioning and also I don't think there will be a lot of versions here. |
oneDNN itself uses a struct to describe its version, so I thought it would be logical to follow the same pattern. A structure allows you to include additional fields like commit hash and probably other meta information regarding supported features (cpu/gpu build, etc). We can theoretically store the same info in an integer (except for commit hash) and provide a bunch of macroses to work with it (like level-zero for example), I don't have a strong preference here |
| @@ -1,6 +1,5 @@ | |||
| cmake_minimum_required(VERSION 3.20) | |||
| project(GraphCompiler LANGUAGES C CXX) | |||
|
|
|||
| project(GraphCompiler VERSION "0.1.0" LANGUAGES C CXX) | |||
There was a problem hiding this comment.
this is the ${PROJECT_VERSION}, this one should be bumped on new releases
| @@ -0,0 +1,25 @@ | |||
| include_guard() | |||
There was a problem hiding this comment.
the logic was mostly copied from oneDNN/cmake/version.cmake
dchigarev
changed the title
kurapov-peter
force-pushed
the
update_gc_api
branch
from
90c1e0c to
48edd90
Compare
Signed-off-by: Dmitry Chigarev <[email protected]>
Align with the GC API changes made in kurapov-peter/oneDNN#1 (implemented a getter function for GC version
dnnl_graph_compiler_get_version)