-
Notifications
You must be signed in to change notification settings - Fork 17
add cpu runner #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
add cpu runner #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ijie/add-cpu-runner
ZhennanQin
reviewed
May 13, 2024
src/gc-cpu-runner/CMakeLists.txt
Outdated
) | ||
endif() | ||
set(MLIR_LINK_COMPONENTS | ||
MLIRAnalysis |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a comment about where to get this list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, done.
ZhennanQin
approved these changes
May 13, 2024
kurapov-peter
approved these changes
May 13, 2024
ciyongch
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
gc-cpu-runner
. Also movegc-opt
insrc/gc-opt
directory. LLVM's cmake function forces us to do that. If we add more than 1 target in the same directory, it complains:So we cannot put
gc-cpu-runner.cpp
andgc-opt.cpp
in the same directory.Another change to the build system is that we change the output LLVM tool binary directory to
bin/
of the cmake build directory, to make suregc-cpu-runner
andgc-opt
are generated in the same directory, for the sake oflit
to correctly find the binaries.