Skip to content

add cpu runner #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 14, 2024
Merged

add cpu runner #65

merged 9 commits into from
May 14, 2024

Conversation

Menooker
Copy link

Add gc-cpu-runner. Also move gc-opt in src/gc-opt directory. LLVM's cmake function forces us to do that. If we add more than 1 target in the same directory, it complains:

CMake Error at /llvm/lib/cmake/llvm/LLVMProcessSources.cmake:116 (message):
  Found erroneous configuration for source file gc-cpu-runner.cpp

  LLVM's build system enforces that all source files are added to a build
  target, that exactly one build target exists in each directory, and that
  this target lists all files in that directory.  If you want multiple
  targets in the same directory, add PARTIAL_SOURCES_INTENDED to the target
  specification, though it is discouraged.

So we cannot put gc-cpu-runner.cpp and gc-opt.cpp in the same directory.

Another change to the build system is that we change the output LLVM tool binary directory to bin/ of the cmake build directory, to make sure gc-cpu-runner and gc-opt are generated in the same directory, for the sake of lit to correctly find the binaries.

@Menooker Menooker requested a review from ciyongch May 13, 2024 03:28
)
endif()
set(MLIR_LINK_COMPONENTS
MLIRAnalysis
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment about where to get this list.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, done.

@Menooker Menooker merged commit 0d8210e into main May 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants