Skip to content

deployment fixes #1338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 22, 2023
Merged

deployment fixes #1338

merged 3 commits into from
Feb 22, 2023

Conversation

mythi
Copy link
Contributor

@mythi mythi commented Feb 21, 2023

Fixes: #1212

@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2023

Codecov Report

Merging #1338 (caa1b76) into main (5912669) will decrease coverage by 0.07%.
The diff coverage is n/a.

❗ Current head caa1b76 differs from pull request most recent head 3dc815c. Consider uploading reports for the commit 3dc815c to get more accurate results

@@            Coverage Diff             @@
##             main    #1338      +/-   ##
==========================================
- Coverage   51.24%   51.17%   -0.07%     
==========================================
  Files          44       44              
  Lines        4879     4879              
==========================================
- Hits         2500     2497       -3     
- Misses       2237     2239       +2     
- Partials      142      143       +1     
Impacted Files Coverage Δ
pkg/deviceplugin/server.go 83.33% <0.00%> (-1.73%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tkatila
Copy link
Contributor

tkatila commented Feb 21, 2023

In ../fpga_plugin/base/role_binding.yaml there is still "namespace: system". Should that also be removed?

@mythi
Copy link
Contributor Author

mythi commented Feb 21, 2023

In ../fpga_plugin/base/role_binding.yaml there is still "namespace: system". Should that also be removed?

Good point. I will have to investigate but it looks right now this is wrong at least.

@mythi
Copy link
Contributor Author

mythi commented Feb 22, 2023

In ../fpga_plugin/base/role_binding.yaml there is still "namespace: system". Should that also be removed?

Good point. I will have to investigate but it looks right now this is wrong at least.

I restored it back to what it was.

@mythi
Copy link
Contributor Author

mythi commented Feb 22, 2023

@hj-johannes-lee please approve

@tkatila tkatila merged commit fd67c5c into intel:main Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

namespaces "intelfpgaplugin-system" not found
4 participants