dlb: make init script end with exit 0 when sriov_numvfs not found #1428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hj-johannes-lee
requested review from
tkatila,
bart0sh,
mythi and
kad
as code owners
mythi
reviewed
May 23, 2023
hj-johannes-lee
changed the title
Even if sriov_numvfs is not found, do not finish with an error. It is necessary because VM still recognizes VF's BDF as xx.xx.0, and script tries to find sriov_numvfs. So, chnage the script just print some informational message and end with exit 0. Signed-off-by: Hyeongju Johannes Lee <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1428 +/- ##
=======================================
Coverage 51.08% 51.08%
=======================================
Files 44 44
Lines 5005 5005
=======================================
Hits 2557 2557
Misses 2302 2302
Partials 146 146 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
tkatila
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even if sriov_numvfs is not found, do not finish with an error.
It is necessary because VM still recognizes VF's BDF as xx.xx.0,
and script tries to find sriov_numvfs. So, chnage the script just
print some informational message and end with exit 0.