Multiple Coverity Fixes

Multiple fixes of various coverity issues, mostly connected with
uninitialized variables in classes, copying and reference and rule of
three.

Author: MiloszSkobejko

IGC/Compiler/HandleLoadStoreInstructions.hpp

@@ -50,7 +50,7 @@ namespace IGC
         void HandleLoadStore();
 
         /// @brief  Indicates if the pass changed the processed function
-        bool m_changed;
+        bool m_changed = false;
     };
 
 } // namespace IGC

IGC/Compiler/Optimizer/OpenCLPasses/CorrectlyRoundedDivSqrt/CorrectlyRoundedDivSqrt.hpp

@@ -58,7 +58,7 @@ namespace IGC
         llvm::Value* emitIEEEDivide(llvm::BinaryOperator* I, llvm::Value* Op0, llvm::Value* Op1);
 
         /// @brief  Indicates if the pass changed the processed function
-        bool m_changed;
+        bool m_changed = false;
 
         /// @brief  Indicates that correctly rounded sqrt/div should be used even
         ///         when the option is not present in the module metadata.

IGC/Compiler/Optimizer/OpenCLPasses/ExtensionFuncs/ExtensionFuncResolution.hpp

@@ -61,7 +61,7 @@ namespace IGC
         ImplicitArgs m_implicitArgs;
 
         /// @brief  Indicates if the pass changed the processed function
-        bool m_changed;
+        bool m_changed = false;
     };
 
 } // namespace IGC

IGC/Compiler/Optimizer/OpenCLPasses/ImageFuncs/ResolveSampledImageBuiltins.hpp

@@ -44,7 +44,7 @@ namespace IGC
         llvm::Value* lowerGetImage(llvm::CallInst& CI);
         llvm::Value* lowerGetSampler(llvm::CallInst& CI);
 
-        bool m_changed;
+        bool m_changed = false;
         std::unordered_set<llvm::CallInst*> m_builtinsToRemove;
     };
 

IGC/Compiler/Optimizer/OpenCLPasses/JointMatrixFuncsResolutionPass/JointMatrixFuncsResolutionPass.cpp

@@ -1345,7 +1345,7 @@ Value *JointMatrixFuncsResolutionPass::ResolveWILength(CallInst *CI) {
     Type *matTy = ResolveType(CI->getArgOperand(0)->getType(), &desc);
 
     const int sliceSize = getSliceSize(&desc, matTy);
-    Value *lenght = ConstantInt::get(CI->getType(), sliceSize, "matrix.slice.size");
+    Value *lenght = ConstantInt::get(CI->getType(), sliceSize);
 
     CI->replaceAllUsesWith(lenght);
     InstsToErase.insert(CI);

visa/G4_Verifier.hpp

@@ -47,6 +47,9 @@ class G4Verifier {
 
 public:
   G4Verifier(G4_Kernel &k, VerifyControl ctrl, Optimizer::PassIndex index);
+  G4Verifier(const G4Verifier&) = delete;
+  G4Verifier& operator=(const G4Verifier&) = delete;
+
 
   ~G4Verifier() {
     if (dumpText.is_open())

visa/GraphColor.h

@@ -561,6 +561,8 @@ class Augmentation {
 public:
   Augmentation(Interference &i, const LivenessAnalysis &l, GlobalRA &g);
   ~Augmentation();
+  Augmentation(const Augmentation&) = delete;
+  Augmentation& operator=(const Augmentation&) = delete;
 
   void augmentIntfGraph();
 
@@ -896,6 +898,8 @@ class Interference {
 
 public:
   Interference(const LivenessAnalysis *l, GlobalRA &g);
+  Interference(const Interference&) = delete;
+  Interference& operator=(const Interference&) = delete;
 
   ~Interference() {
     if (useDenseMatrix()) {

visa/Timer.h

@@ -51,6 +51,9 @@ struct TimerScope {
   TimerScope(const TimerID _timerId) : timerId(_timerId) {
     startTimer(timerId);
   }
+
+  TimerScope(const TimerScope&) = delete;
+  TimerScope& operator=(const TimerScope&) = delete;
   ~TimerScope() { stopTimer(timerId); }
 };
 

visa/VISAKernel.h

@@ -1125,7 +1125,7 @@ class VISAKernelImpl : public VISAFunction {
   void setJitInfo(vISA::FINALIZER_INFO *jitInfo) { m_jitInfo = jitInfo; }
 
   std::string getOutputAsmPath() const { return m_asmName; }
-  void setOutputAsmPath(std::string val) { m_asmName = val; }
+  void setOutputAsmPath(const std::string& val) { m_asmName = val; }
 
   int compileFastPath();
 

visa/include/RelocationInfo.h

@@ -87,7 +87,7 @@ struct ZESymEntry {
 
   ZESymEntry() = default;
   ZESymEntry(GenSymType type, uint32_t offset, uint32_t size, std::string name)
-      : s_type(type), s_offset(offset), s_size(size), s_name(name) {}
+      : s_type(type), s_offset(offset), s_size(size), s_name(std::move(name)) {}
 };
 
 /// ZERelocEntry - A relocation entry that will later be transformed to ZE
@@ -101,7 +101,7 @@ struct ZERelocEntry {
 
   ZERelocEntry() = default;
   ZERelocEntry(GenRelocType type, uint32_t offset, std::string targetSymName)
-      : r_type(type), r_offset(offset), r_symbol(targetSymName) {}
+      : r_type(type), r_offset(offset), r_symbol(std::move(targetSymName)) {}
 };
 
 /// ZEFuncAttribEntry - A function attribute entry that will later be
@@ -123,7 +123,7 @@ struct ZEFuncAttribEntry {
       : f_isKernel(isKernel), f_isExternal(isExternal),
         f_BarrierCount(barrierCount),
         f_privateMemPerThread(privateMemPerThread),
-        f_spillMemPerThread(spillMemPerThread), f_name(funcName), f_hasRTCalls(hasRTCalls) {}
+        f_spillMemPerThread(spillMemPerThread), f_name(std::move(funcName)), f_hasRTCalls(hasRTCalls) {}
 };
 
 /// ZEHostAccessEntry - A host access entry that will later be transformed to ZE