Skip to content

Commit 3e2559b

Browse files
iwwuigcbot
authored andcommitted
Turn on UseVMaskPredicate as the default
Enable pixel shader interpolation optimization with vmask predicate optimization. Limit the change to emitPSInput only
1 parent ba7f4cd commit 3e2559b

File tree

2 files changed

+1
-5
lines changed

2 files changed

+1
-5
lines changed

IGC/Compiler/CISACodeGen/EmitVISAPass.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4033,8 +4033,6 @@ void EmitPass::EmitGenericPointersCmp(llvm::Instruction* inst,
40334033

40344034
void EmitPass::BinaryUnary(llvm::Instruction* inst, const SSource source[2], const DstModifier& modifier)
40354035
{
4036-
UseVMaskPred();
4037-
40384036
switch (inst->getOpcode())
40394037
{
40404038
case Instruction::FCmp:
@@ -4447,8 +4445,6 @@ void EmitPass::Unary(e_opcode opCode, const SSource sources[1], const DstModifie
44474445
template<int N>
44484446
void EmitPass::Alu(e_opcode opCode, const SSource sources[N], const DstModifier& modifier)
44494447
{
4450-
UseVMaskPred();
4451-
44524448
CVariable* srcs[3] = { nullptr, nullptr, nullptr };
44534449
for (uint i = 0; i < N; i++)
44544450
{

IGC/common/igc_flags.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -403,7 +403,7 @@ DECLARE_IGC_REGKEY(bool, UseMTInLLD, false, "Use multi-thread
403403
DECLARE_IGC_REGKEY(bool, NoCatchAllDebugLine, false, "Don't emit special placeholder instruction to map VISA orphan instructions", false)
404404
DECLARE_IGC_REGKEY(bool, EnableTestSplitI64, false, "Test legalization that split i64 store unnecessarily, to be deleted once test is done[temp]", true)
405405
DECLARE_IGC_REGKEY(bool, ShaderDumpTranslationOnly, false, "Dump LLVM IR right after translation from SPIRV to stderr and ignore all passes", false)
406-
DECLARE_IGC_REGKEY(bool, UseVMaskPredicate, false, "Use VMask as predicate for subspan usage", false)
406+
DECLARE_IGC_REGKEY(bool, UseVMaskPredicate, true, "Use VMask as predicate for subspan usage", false)
407407
DECLARE_IGC_REGKEY(bool, StackOverflowDetection, false, "Inserts checks for stack overflow when stack calls are used.", true)
408408

409409
DECLARE_IGC_GROUP("IGC Features")

0 commit comments

Comments
 (0)