Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

Commit f531ccf

Browse files
authored
Marked hip_nvidia failing tests that do not also fail for cuda or hip_amd XFAIL. (#525)
There are some common failures during queue instantiation caused by failure to find the correct device using hip_nvidia backend. Signed-off-by: JackAKirk <[email protected]>
1 parent 82717ca commit f531ccf

21 files changed

+47
-1
lines changed

SYCL/Basic/diagnostics/handler.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
// RUN: %clangxx -fsycl -fsycl-targets=%sycl_triple %s -o %t.out
22
// RUN: %BE_RUN_PLACEHOLDER %t.out | FileCheck %s
3+
//
4+
// Appears to fail on HIP Nvidia because 'no device of requested type available'
5+
// when constructing a queue with an exception_list.
6+
// XFAIL: hip_nvidia
37
//==------------------- handler.cpp ----------------------------------------==//
48
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
59
// See https://llvm.org/LICENSE.txt for license information.

SYCL/Basic/memory-consumption.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
// RUN: %clangxx -fsycl %s -o %t.out
22
// RUN: %GPU_RUN_PLACEHOLDER %t.out
33
//
4+
// XFAIL: hip_nvidia
45
// Issue #106: The test failing sporadically on OpenCL platform due to
56
// processing OCL_ICD_FILENAMES debug environment variable which causes
67
// extra memory allocation on device creation.

SYCL/Basic/partition_supported.cpp

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,9 @@
22
// RUN: %CPU_RUN_PLACEHOLDER %t.out
33
// RUN: %GPU_RUN_PLACEHOLDER %t.out
44
// RUN: %ACC_RUN_PLACEHOLDER %t.out
5-
5+
//
6+
// Nvidia should not allow sub_devices but does not throw corresponding error.
7+
// XFAIL: hip_nvidia
68
/* Check that:
79
1) [info::device::partition_properties]: returns the partition properties
810
supported by this SYCL device; a vector of info::partition_property. If this

SYCL/Basic/queue/queue.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
// RUN: %clangxx -fsycl -fsycl-targets=%sycl_triple %s -o %t.out
22
// RUN: %BE_RUN_PLACEHOLDER %t.out
3+
//
4+
// XFAIL: hip_nvidia
35
//==--------------- queue.cpp - SYCL queue test ----------------------------==//
46
//
57
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.

SYCL/Basic/queue/release.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
// RUN: env SYCL_PI_TRACE=2 %GPU_RUN_PLACEHOLDER %t.out %GPU_CHECK_PLACEHOLDER
33
// RUN: env SYCL_PI_TRACE=2 %CPU_RUN_PLACEHOLDER %t.out %CPU_CHECK_PLACEHOLDER
44
// RUN: env SYCL_PI_TRACE=2 %ACC_RUN_PLACEHOLDER %t.out %ACC_CHECK_PLACEHOLDER
5+
//
6+
// XFAIL: hip_nvidia
57

68
#include <CL/sycl.hpp>
79
int main() {

SYCL/Basic/stream/auto_flush.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
// RUN: %CPU_RUN_PLACEHOLDER %t.out %CPU_CHECK_PLACEHOLDER
44
// RUN: %GPU_RUN_ON_LINUX_PLACEHOLDER %t.out %GPU_CHECK_ON_LINUX_PLACEHOLDER
55
// RUN: %ACC_RUN_PLACEHOLDER %t.out %ACC_CHECK_PLACEHOLDER
6+
//
7+
// XFAIL: hip_nvidia
68
//==-------------- copy.cpp - SYCL stream obect auto flushing test ---------==//
79
//
810
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.

SYCL/DeprecatedFeatures/kernel_info.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
//
66
// Fail is flaky for level_zero, enable when fixed.
77
// UNSUPPORTED: level_zero
8+
//
9+
// XFAIL: hip_nvidia
810

911
//==--- kernel_info.cpp - SYCL kernel info test ----------------------------==//
1012
//

SYCL/DeprecatedFeatures/queue_old_interop.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
// RUN: %clangxx -fsycl -fsycl-targets=%sycl_triple -D__SYCL_INTERNAL_API %s -o %t.out
22
// RUN: %BE_RUN_PLACEHOLDER %t.out
3+
//
4+
// hip_nvidia has problems constructing queues due to `No device of requested
5+
// type available`.
6+
// XFAIL: hip_nvidia
37
//==-------- queue_old_interop.cpp - SYCL queue OpenCL interop test --------==//
48
//
59
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.

SYCL/DeviceCodeSplit/split-per-kernel.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
// RUN: %CPU_RUN_PLACEHOLDER %t.out
33
// RUN: %GPU_RUN_PLACEHOLDER %t.out
44
// RUN: %ACC_RUN_PLACEHOLDER %t.out
5+
//
6+
// XFAIL: hip_nvidia
57

68
#include <CL/sycl.hpp>
79

SYCL/DeviceCodeSplit/split-per-source-main.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
// RUN: %CPU_RUN_PLACEHOLDER %t.out
33
// RUN: %GPU_RUN_PLACEHOLDER %t.out
44
// RUN: %ACC_RUN_PLACEHOLDER %t.out
5+
//
6+
// XFAIL: hip_nvidia
57

68
#include "Inputs/split-per-source.h"
79

SYCL/GroupLocalMemory/group_local_memory.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
// RUN: %CPU_RUN_PLACEHOLDER %t.out
33
// RUN: %GPU_RUN_PLACEHOLDER %t.out
44
// RUN: %ACC_RUN_PLACEHOLDER %t.out
5+
//
6+
// XFAIL: hip_nvidia
57

68
#include <CL/sycl.hpp>
79

SYCL/GroupLocalMemory/no_early_opt.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
// RUN: %CPU_RUN_PLACEHOLDER %t.out
33
// RUN: %GPU_RUN_PLACEHOLDER %t.out
44
// RUN: %ACC_RUN_PLACEHOLDER %t.out
5+
//
6+
// XFAIL: hip_nvidia
57

68
// The test checks that multiple calls to the same template instantiation of a
79
// group local memory function result in separate allocations, even with device

SYCL/InorderQueue/in_order_property_trace.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
// RUN: %clangxx -fsycl -fsycl-targets=%sycl_triple %s -o %t.out
22
// RUN: env SYCL_PI_TRACE=2 %CPU_RUN_PLACEHOLDER %t.out 2>&1 %CPU_CHECK_PLACEHOLDER
33
// RUN: env SYCL_PI_TRACE=2 %GPU_RUN_PLACEHOLDER %t.out 2>&1 %GPU_CHECK_PLACEHOLDER
4+
//
5+
// XFAIL: hip_nvidia
46
// SYCL in order and default queue property trace test
57
//
68
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.

SYCL/Reduction/reduction_reducer_op_eq.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22
// RUN: %CPU_RUN_PLACEHOLDER %t.out
33
// RUN: %GPU_RUN_PLACEHOLDER %t.out
44
// RUN: %ACC_RUN_PLACEHOLDER %t.out
5+
//
6+
// On nvidia a reduction appears to be unexpectedly executed via the host.
7+
// XFAIL: hip_nvidia
58

69
// This test checks that operators ++, +=, *=, |=, &=, ^= are supported
710
// whent the corresponding std::plus<>, std::multiplies, etc are defined.

SYCL/Regression/context_is_destroyed_after_exception.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22

33
// RUN: %clangxx -fsycl %s -o %t.out
44
// RUN: env SYCL_PI_TRACE=2 %GPU_RUN_PLACEHOLDER %t.out 2>&1 %GPU_CHECK_PLACEHOLDER
5+
//
6+
// XFAIL: hip_nvidia
57

68
#include <CL/sycl.hpp>
79

SYCL/Scheduler/InOrderQueueDeps.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
// RUN: env SYCL_PI_TRACE=2 %CPU_RUN_PLACEHOLDER %t.out 2>&1 %CPU_CHECK_PLACEHOLDER
44
// RUN: env SYCL_PI_TRACE=2 %GPU_RUN_PLACEHOLDER %t.out 2>&1 %GPU_CHECK_PLACEHOLDER
55
// RUN: env SYCL_PI_TRACE=2 %ACC_RUN_PLACEHOLDER %t.out 2>&1 %ACC_CHECK_PLACEHOLDER
6+
//
7+
// XFAIL: hip_nvidia
68

79
// The tested functionality is disabled with Level Zero until it is supported by
810
// the plugin.

SYCL/Scheduler/MemObjRemapping.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
// RUN: %clangxx -fsycl -fsycl-targets=%sycl_triple %s -o %t.out
22
// RUN: env SYCL_HOST_UNIFIED_MEMORY=1 SYCL_PI_TRACE=2 %CPU_RUN_PLACEHOLDER %t.out 2>&1 %CPU_CHECK_PLACEHOLDER
33
// RUN: env SYCL_HOST_UNIFIED_MEMORY=1 SYCL_PI_TRACE=2 %GPU_RUN_PLACEHOLDER %t.out 2>&1 %GPU_CHECK_PLACEHOLDER
4+
//
5+
// XFAIL: hip_nvidia
46
#include <CL/sycl.hpp>
57
#include <cassert>
68
#include <cstddef>

SYCL/Scheduler/MultipleDevices.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
// RUN: %clangxx -fsycl -fsycl-targets=%sycl_triple %s -o %t.out
22
// RUN: env SYCL_DEVICE_FILTER=%sycl_be %t.out
3+
//
4+
// XFAIL: hip_nvidia
35

46
//===- MultipleDevices.cpp - Test checking multi-device execution --------===//
57
//

SYCL/Scheduler/ReleaseResourcesTest.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
// RUN: env SYCL_PI_TRACE=2 %CPU_RUN_PLACEHOLDER %t.out 2>&1 %CPU_CHECK_PLACEHOLDER
44
// RUN: env SYCL_PI_TRACE=2 %GPU_RUN_PLACEHOLDER %t.out 2>&1 %GPU_CHECK_PLACEHOLDER
55
// RUN: env SYCL_PI_TRACE=2 %ACC_RUN_PLACEHOLDER %t.out 2>&1 %ACC_CHECK_PLACEHOLDER
6+
//
7+
// XFAIL: hip_nvidia
68

79
//==------------------- ReleaseResourcesTests.cpp --------------------------==//
810
//

SYCL/Tracing/buffer_printers.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
// RUN: env SYCL_PI_TRACE=2 %GPU_RUN_PLACEHOLDER %t.out %GPU_CHECK_PLACEHOLDER
33
// RUN: env SYCL_PI_TRACE=2 %CPU_RUN_PLACEHOLDER %t.out %CPU_CHECK_PLACEHOLDER
44
// RUN: env SYCL_PI_TRACE=2 %ACC_RUN_PLACEHOLDER %t.out %ACC_CHECK_PLACEHOLDER
5+
//
6+
// XFAIL: hip_nvidia
57

68
#include <CL/sycl.hpp>
79
#include <vector>

SYCL/Tracing/pi_tracing_test.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
// RUN: env SYCL_PI_TRACE=-1 %CPU_RUN_PLACEHOLDER %t.out %CPU_CHECK_PLACEHOLDER
33
// RUN: env SYCL_PI_TRACE=-1 %GPU_RUN_PLACEHOLDER %t.out %GPU_CHECK_PLACEHOLDER
44
// RUN: env SYCL_PI_TRACE=-1 %ACC_RUN_PLACEHOLDER %t.out %ACC_CHECK_PLACEHOLDER
5+
//
6+
// XFAIL: hip_nvidia
57

68
// Test tracing of the Plugin Interface
79

0 commit comments

Comments
 (0)