Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

Marked remaining hip_nvidia failing tests XFAIL #525

Merged
merged 1 commit into from
Oct 21, 2021

Conversation

JackAKirk
Copy link

Marked hip_nvidia failing tests that do not also fail for cuda or hip_amd XFAIL.

There are some common failures during queue instantiation caused by failure to find correct device using hip_nvidia backend.

Signed-off-by: JackAKirk [email protected]

…_amd XFAIL.

There are some common failures during queue instantiation caused by failure to find correct device using hip_nvidia backend.

Signed-off-by: JackAKirk <[email protected]>
@vladimirlaz vladimirlaz merged commit f531ccf into intel:intel Oct 21, 2021
@bader
Copy link

bader commented Dec 21, 2021

@JackAKirk, I see that https://github.com/intel/llvm-test-suite/blob/intel/SYCL/Basic/memory-consumption.cpp fails on hip_amd - https://github.com/intel/llvm/runs/4582224027?check_suite_focus=true. This is pre-commit results for intel/llvm#5185, but I don't think this failure is caused by the changes in the pull request.
It looks like the test fails sporadically.
Does it make sense to file a bug to instigate this issue and replace "XFAIL: hip_nvidia" with "UNSUPPORTED: hip"?

@JackAKirk
Copy link
Author

Yes if it fails on hip_amd marking it "UNSUPPORTED: hip" sounds good. We can mark it for investigation since I don't think that anyone understands exactly why this particular test failed for hip_nvidia (or hip_amd) yet.

@alexbatashev
Copy link

Yes if it fails on hip_amd marking it "UNSUPPORTED: hip" sounds good. We can mark it for investigation since I don't think that anyone understands exactly why this particular test failed for hip_nvidia (or hip_amd) yet.

This seems to be sporadic, because I don’t see it on other commits.

aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
…_amd XFAIL. (intel/llvm-test-suite#525)

There are some common failures during queue instantiation caused by failure to find the correct device using hip_nvidia backend.

Signed-off-by: JackAKirk <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants