This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Add optimized/non-optimized CHECKs for SYCL/XPTI/kernel/* #1000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the test-suite was configured to pass -O0 the tests were changing their behavior because no dead kernel arguments optimization was performed, resulting in failing CHECKs. Be explicit in the "RUN:" commands and expected "CHECK:" lines.
againull
previously approved these changes
Apr 19, 2022
The latter isn't the spelling of the option on Windows.
againull
approved these changes
Apr 20, 2022
|
All the failures are unrelated to the tests modified here. Patch is ready to be merged in. @againull , could you please help with this? |
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Jun 17, 2022
…el#1000) If the test-suite was configured to pass -O0 the tests were changing their behavior because no dead kernel arguments optimization was performed, resulting in failing CHECKs. Be explicit in the "RUN:" commands and expected "CHECK:" lines.
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Jun 17, 2022
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…el/llvm-test-suite#1000) If the test-suite was configured to pass -O0 the tests were changing their behavior because no dead kernel arguments optimization was performed, resulting in failing CHECKs. Be explicit in the "RUN:" commands and expected "CHECK:" lines.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the test-suite was configured to pass -O0 the tests were changing their
behavior because no dead kernel arguments optimization was performed, resulting
in failing CHECKs.
Be explicit in the "RUN:" commands and expected "CHECK:" lines.