Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

Update tests in preparation for default device instrumentation #1017

Merged
merged 3 commits into from
May 12, 2022

Conversation

mdtoguchi
Copy link

The behavior of -fsycl-instrument-device-code has modified the requirements
for tests which perform separate compilation. Update these tests to pull
in the needed device code to alleviate issues as seen below:

Error: unimplemented function(s) used:
__itt_offload_wi_start_wrapper is undefined
__itt_offload_wi_finish_wrapper is undefined
CompilerException Failed to parse IR
-17 (CL_LINK_PROGRAM_FAILURE)

Signed-off-by: Michael D Toguchi [email protected]

mdtoguchi added 3 commits May 4, 2022 13:37
The behavior of -fsycl-instrument-device-code has modified the requirements
for tests which perform separate compilation.  Update these tests to pull
in the needed device code to alleviate issues as seen below:

Error: unimplemented function(s) used:
__itt_offload_wi_start_wrapper is undefined
__itt_offload_wi_finish_wrapper is undefined
CompilerException Failed to parse IR
-17 (CL_LINK_PROGRAM_FAILURE)

Signed-off-by: Michael D Toguchi <[email protected]>
Use proper object extension and device lib location
@mdtoguchi mdtoguchi marked this pull request as ready for review May 5, 2022 19:10
@mdtoguchi mdtoguchi requested review from a team as code owners May 5, 2022 19:10
@mdtoguchi mdtoguchi requested a review from steffenlarsen May 5, 2022 19:10
Copy link

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mdtoguchi
Copy link
Author

@intel/dpcpp-tools-reviewers, can you take a look?

@mdtoguchi
Copy link
Author

@intel/llvm-gatekeepers, can this be merged, or do we need additional reviews?

Copy link

@asudarsa asudarsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks.

@pvchupin pvchupin merged commit 46a229e into intel:intel May 12, 2022
myler pushed a commit to myler/llvm-test-suite that referenced this pull request Jun 17, 2022
…#1017)

The behavior of -fsycl-instrument-device-code has modified the requirements
for tests which perform separate compilation. Update these tests to pull
in the needed device code to alleviate issues as seen below:

Error: unimplemented function(s) used:
__itt_offload_wi_start_wrapper is undefined
__itt_offload_wi_finish_wrapper is undefined
CompilerException Failed to parse IR
-17 (CL_LINK_PROGRAM_FAILURE)

Signed-off-by: Michael D Toguchi [email protected]
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
…/llvm-test-suite#1017)

The behavior of -fsycl-instrument-device-code has modified the requirements
for tests which perform separate compilation. Update these tests to pull
in the needed device code to alleviate issues as seen below:

Error: unimplemented function(s) used:
__itt_offload_wi_start_wrapper is undefined
__itt_offload_wi_finish_wrapper is undefined
CompilerException Failed to parse IR
-17 (CL_LINK_PROGRAM_FAILURE)

Signed-off-by: Michael D Toguchi [email protected]
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants