This repository was archived by the owner on Mar 28, 2023. It is now read-only.
forked from llvm/llvm-test-suite
-
Notifications
You must be signed in to change notification settings - Fork 130
Update tests in preparation for default device instrumentation #1017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The behavior of -fsycl-instrument-device-code has modified the requirements for tests which perform separate compilation. Update these tests to pull in the needed device code to alleviate issues as seen below: Error: unimplemented function(s) used: __itt_offload_wi_start_wrapper is undefined __itt_offload_wi_finish_wrapper is undefined CompilerException Failed to parse IR -17 (CL_LINK_PROGRAM_FAILURE) Signed-off-by: Michael D Toguchi <[email protected]>
Use proper object extension and device lib location
steffenlarsen
approved these changes
May 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@intel/dpcpp-tools-reviewers, can you take a look? |
@intel/llvm-gatekeepers, can this be merged, or do we need additional reviews? |
asudarsa
approved these changes
May 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks.
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Jun 17, 2022
…#1017) The behavior of -fsycl-instrument-device-code has modified the requirements for tests which perform separate compilation. Update these tests to pull in the needed device code to alleviate issues as seen below: Error: unimplemented function(s) used: __itt_offload_wi_start_wrapper is undefined __itt_offload_wi_finish_wrapper is undefined CompilerException Failed to parse IR -17 (CL_LINK_PROGRAM_FAILURE) Signed-off-by: Michael D Toguchi [email protected]
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…/llvm-test-suite#1017) The behavior of -fsycl-instrument-device-code has modified the requirements for tests which perform separate compilation. Update these tests to pull in the needed device code to alleviate issues as seen below: Error: unimplemented function(s) used: __itt_offload_wi_start_wrapper is undefined __itt_offload_wi_finish_wrapper is undefined CompilerException Failed to parse IR -17 (CL_LINK_PROGRAM_FAILURE) Signed-off-by: Michael D Toguchi [email protected]
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behavior of -fsycl-instrument-device-code has modified the requirements
for tests which perform separate compilation. Update these tests to pull
in the needed device code to alleviate issues as seen below:
Error: unimplemented function(s) used:
__itt_offload_wi_start_wrapper is undefined
__itt_offload_wi_finish_wrapper is undefined
CompilerException Failed to parse IR
-17 (CL_LINK_PROGRAM_FAILURE)
Signed-off-by: Michael D Toguchi [email protected]