This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Reenable GroupAlgorithm tests #1021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ferred when we were only supporting early versions of SPIR-V. We've long since moved on, yet the tests remained truncate. Here I am reenabling them to prevent any further regressions sneaking in. Note that there are a couple casescommented out because of L0 failures. I haven't investigated that yet, I'm merely opening a draft PR to make sure this first enablement is working as intended. Signed-off-by: Chris Perkins <[email protected]>
… fixed Signed-off-by: Chris Perkins <[email protected]>
|
The test failure is unrelated (and flaky). |
steffenlarsen
approved these changes
May 19, 2022
|
ping to get this finalized/merged. |
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Jun 17, 2022
Some of the group algorithm operations had their full test coverage deferred when we were only supporting early versions of SPIR-V. We've long since moved on, yet the tests remained truncate. Here I am reenabling them to prevent any further regressions sneaking in. Note that there are a couple cases commented out because of L0 failures. I haven't investigated that yet, I'm merely opening a draft PR to make sure this first enablement is working as intended. Signed-off-by: Chris Perkins <[email protected]>
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
[SYCL][L0] re-enable SYCL/Plugin/level_zero_batch_barrier.cpp (intel#1092)
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
Some of the group algorithm operations had their full test coverage deferred when we were only supporting early versions of SPIR-V. We've long since moved on, yet the tests remained truncate. Here I am reenabling them to prevent any further regressions sneaking in. Note that there are a couple cases commented out because of L0 failures. I haven't investigated that yet, I'm merely opening a draft PR to make sure this first enablement is working as intended. Signed-off-by: Chris Perkins <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the GroupAlgorithm operations had their full test coverage deferred when we were only supporting early versions of SPIR-V. We've long since moved on, yet the tests remained truncated. Here I am reenabling them to prevent any further regressions sneaking in. There was also a small bug in the unexercised code where we inadvertently used out-of-bounds checks with the smaller input datas.
Signed-off-by: Chris Perkins [email protected]