Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL] Reduce memory size to reduce test complexity and avoid flaky memory related issues #1036

Merged

Conversation

asudarsa
Copy link

This testcase is used to test whether compute and copy commands are handled correctly in an expected way. Size of memory is not important for this test. However, existing testcase makes unnecessary use of large array sizes. This could have been the cause behind some of the flaky test failures seen in testing. This change reduces the memory size and should help to avoid any memory related failures.

@asudarsa asudarsa requested a review from a team as a code owner May 24, 2022 00:11
@asudarsa asudarsa requested a review from bader May 24, 2022 13:17
Copy link

@bader bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Reduce memory size to reduce test complexity

I agree with that part.

and avoid flaky memory related issues

I don't understand the rootcause of "flaky memory related issues" to agree with the second part. @asudarsa, please, share more details on what is causing these issues if you have them.

@asudarsa
Copy link
Author

asudarsa commented Jun 5, 2022

Hi @bader
I am not able to reproduce this failure locally (tried a lot of permutations). My hypothesis s that the 'high' memory requirements of this test s the root cause for the failure of this test in a CI environment. We can look for other possible causes if we see this fail after this change. Thanks

@bader
Copy link

bader commented Jun 5, 2022

My hypothesis s that the 'high' memory requirements of this test s the root cause for the failure of this test in a CI environment.

Did you try testing this hypothesis by increasing memory requirements in this test?
It should help to expose the issue frequent enough for reproducing and debugging.

@againull againull merged commit f5faacd into intel:intel Jun 5, 2022
myler pushed a commit to myler/llvm-test-suite that referenced this pull request Jun 17, 2022
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants