Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL] Add more GPU options to available features #1047

Merged
merged 4 commits into from
Jun 16, 2022
Merged

[SYCL] Add more GPU options to available features #1047

merged 4 commits into from
Jun 16, 2022

Conversation

myler
Copy link

@myler myler commented Jun 7, 2022 •
edited by pvchupin
Loading

add GPU FAMILY to available features and specify ESIMD raw send tests to gpu-intel-gen9

myler added 2 commits June 7, 2022 13:34
@myler
Add available features to manage test running on different HW.
77d2f5d 
1) 'aspect-fp64' for SYCL 2020 aspects.
2) 'supports-subdevice' for non-aspect optional features.
3) Update 50 tests which contain 'double' type data.
@myler
add GPU FAMILY to available features and specify ESIMD raw send tests…
5393753 
… to gpu-intel-gen9
@myler myler marked this pull request as ready for review June 8, 2022 04:56
@myler myler requested review from a team and Pennycook as code owners June 8, 2022 04:56
@myler myler requested a review from cperkinsintel June 8, 2022 04:56
@myler
Copy link
Author

myler commented Jun 8, 2022

Add @pvchupin @steffenlarsen @kbobrovs for code review.

@kbobrovs
Copy link

kbobrovs commented Jun 8, 2022

ESIMD LGTM.
One note:
I can see that Jenkins CI was done on a platform not supporting FP64 (TGLLP?), as many tests are skipped as UNSUPPORTED. I hope we run regular CI on GPU platforms with FP64 supported, otherwise lots of important GPU tests are not run.
@pvchupin, JFYI.

kbobrovs
kbobrovs previously approved these changes Jun 8, 2022
View reviewed changes
Copy link

@kbobrovs kbobrovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESIMD LGTM

@myler
Copy link
Author

myler commented Jun 8, 2022 •
edited
Loading

ESIMD LGTM. One note: I can see that Jenkins CI was done on a platform not supporting FP64 (TGLLP?), as many tests are skipped as UNSUPPORTED. I hope we run regular CI on GPU platforms with FP64 supported, otherwise lots of important GPU tests are not run. @pvchupin, JFYI.

I think not only aspect-fp64 but other identifiers, such as gpu-intel-* are not able to be handled by Jenkins CI, because Jenkins CI doesn't know what aspect-fp64 is. Then many tests returned UNSUPPORTED.

If this change got approval, or more tests want to run via Jenkins CI, it also needs to update, @DoyleLi could you help on this?

  • If device is one of CPU, ACC, or HOST, then double type is native supported, so by default, python lit.py needs an additional option -Daspect-fp64=1
  • If device is GPU, then check whether does GPU HW support double type, if yes, python lit.py needs an additional option -Daspect-fp64=1, e.g. on Gen9 and older GPUs.

In internal infrastructure, we check the dispatched HW features and provide additional options to python lit.py

@kbobrovs
Copy link

kbobrovs commented Jun 8, 2022

I think not only aspect-fp64 but other identifiers, such as gpu-intel-* are not able to be handled by Jenkins CI, because Jenkins CI doesn't know what aspect-fp64 is. Then many tests returned UNSUPPORTED.

Right. My point is that absence of fp64 disables particularly big number of important tests, so it is highly desirable to run CI on GPU with fp64 support.

@pvchupin
Copy link

pvchupin commented Jun 8, 2022

@myler, please fix PR title and description.

pvchupin
pvchupin suggested changes Jun 8, 2022
View reviewed changes
@myler myler requested a review from pvchupin June 13, 2022 00:49
@pvchupin
Copy link

@myler, please update PR description and fix title.

pvchupin
pvchupin reviewed Jun 13, 2022
View reviewed changes
@pvchupin pvchupin requested review from pvchupin and v-klochkov June 13, 2022 20:23
@myler myler changed the title Add available features to manage test running on different HW. 1) 'aspect-fp64' for SYCL 2020 aspects. 2) 'supports-subdevice' for non-aspect optional features. 3) Update 50 tests which contain 'double' type data. Add GPU FAMILY to available features and specify ESIMD raw send tests to gpu-intel-gen9 Jun 14, 2022
@myler
Copy link
Author

myler commented Jun 14, 2022

The failure is not related to this PR, it caused by #888

[2022-06-14T00:41:30.358Z] ********************
[2022-06-14T00:41:30.358Z] Failed Tests (1):
[2022-06-14T00:41:30.358Z]   SYCL :: Basic/aspects.cpp

@myler
Copy link
Author

myler commented Jun 16, 2022

@pvchupin may I ask you to review again?

@myler
Copy link
Author

myler commented Jun 16, 2022

Hi @v-klochkov,

Seems I do not have permission to merge to this protected branch. May I ask you to help to merge this PR or is it possible to let me know how to apply the permission?

@pvchupin pvchupin changed the title Add GPU FAMILY to available features and specify ESIMD raw send tests to gpu-intel-gen9 [SYCL] Add more GPU options to available features Jun 16, 2022
@pvchupin pvchupin merged commit 0108419 into intel:intel Jun 16, 2022
myler added a commit to myler/llvm-test-suite that referenced this pull request Jun 17, 2022
@myler
[SYCL] Add more GPU options to available features (intel#1047)
5f72fc2 
add GPU FAMILY to available features and specify ESIMD raw send tests to gpu-intel-gen9
myler added a commit to myler/llvm-test-suite that referenced this pull request Mar 22, 2023
@myler
[SYCL] Add more GPU options to available features (intel#1047)
70e844d 
add GPU FAMILY to available features and specify ESIMD raw send tests to gpu-intel-gen9
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
@myler
[SYCL] Add more GPU options to available features (intel/llvm-test-su…
1b75a78 
…ite#1047)

add GPU FAMILY to available features and specify ESIMD raw send tests to gpu-intel-gen9
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@v-klochkov v-klochkov v-klochkov approved these changes

@pvchupin pvchupin pvchupin approved these changes

@kbobrovs kbobrovs kbobrovs left review comments

@Pennycook Pennycook Awaiting requested review from Pennycook

@cperkinsintel cperkinsintel Awaiting requested review from cperkinsintel cperkinsintel is a code owner automatically assigned from intel/llvm-reviewers-runtime

@smaslov-intel smaslov-intel Awaiting requested review from smaslov-intel

@steffenlarsen steffenlarsen Awaiting requested review from steffenlarsen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@myler @kbobrovs @pvchupin @v-klochkov