This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Localize variables declared in inline asms. #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rdeodhar <[email protected]>
vladimirlaz
suggested changes
Jan 21, 2021
There was a problem hiding this comment.
@rdeodhar, could you please remove XFAIL: in test if your changes fixes them.
|
XFAIL can be removed after driver update to gfx-driver-ci-comp_igc-8719. |
vladimirlaz
approved these changes
Jan 21, 2021
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…uite#105) Signed-off-by: rdeodhar <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change encloses inline asm blocks that contain variable definitions within { and }, thus localizing the variables. This is needed in case the compiler clones the region of code that contains the inline asms, as is done in the parallel_for range rounding optimization.
Signed-off-by: rdeodhar [email protected]