This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL][libdevice] Test libdevice jit-link mode. #1055
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jinge90 <[email protected]>
Signed-off-by: jinge90 <[email protected]>
Signed-off-by: jinge90 <[email protected]>
|
Hi, @againull Thanks very much. |
againull
reviewed
Jun 14, 2022
| @@ -3,6 +3,11 @@ | |||
| // RUN: %CPU_RUN_PLACEHOLDER %t.out | |||
| // RUN: %ACC_RUN_PLACEHOLDER %t.out | |||
|
|
|||
| // RUN: %clangxx -fsycl -fno-builtin -fsycl-device-lib-jit-link %s -o %t.out | |||
There was a problem hiding this comment.
Could you please clarify why some of the tests have -fno-builtin flag and some of them don't? Is this a workaround for something?
There was a problem hiding this comment.
Hi, @againull
To some math functions, clang may have different ways to handle.
- convert it to a library function call
- instruction expand, use several IR instructions to replace
The tests aim to test implementations in SYCL device library, we need to guarantee all functions to test are converted to corresponding library function call, so adding "-fno-builtin" to force to achieve it.
Thanks very much.
againull
approved these changes
Jun 16, 2022
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
Signed-off-by: jinge90 <[email protected]>
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…e#1055) Signed-off-by: jinge90 <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: jinge90 [email protected]
We added option f[no-]sycl-device-lib-jit-link to control SYCL device library link mode. Currently, jit-link is disabled by default and we explicitly test this option in this PR.