This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL][CUDA] Add cuda_dev_kit feature #1056
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes add a cuda_dev_kit feature check for detecting availability of a CUDA SDK. CUDA include path and library path can be controlled through the new CUDA_INCLUDE and CUDA_LIBS_DIR variables. Signed-off-by: Larsen, Steffen <[email protected]>
| config.cuda_include=lit_config.params.get("cuda_include", (config.cuda_include if config.cuda_include else config.sycl_include)) | ||
|
|
||
| cuda_options=cuda_options = (' -L'+config.cuda_libs_dir if config.cuda_libs_dir else '')+' -lcuda '+' -I'+config.cuda_include | ||
| if cl_options: |
There was a problem hiding this comment.
Should this be cl_options if this is for cuda?
There was a problem hiding this comment.
Level zero uses this too. Seems like an obfuscated way of determining if it is on Windows.
There was a problem hiding this comment.
Okay, many thanks for clarifying.
v-klochkov
previously approved these changes
Jun 13, 2022
steffenlarsen
dismissed stale reviews from v-klochkov and AidanBeltonS
via
3365e06
v-klochkov
approved these changes
Jun 23, 2022
|
Build-log failure is unrelated and has since been fixed. Merging this. |
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
These changes add a cuda_dev_kit feature check for detecting availability of a CUDA SDK. CUDA include path and library path can be controlled through the new CUDA_INCLUDE and CUDA_LIBS_DIR variables. Signed-off-by: Larsen, Steffen <[email protected]>
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
These changes add a cuda_dev_kit feature check for detecting availability of a CUDA SDK. CUDA include path and library path can be controlled through the new CUDA_INCLUDE and CUDA_LIBS_DIR variables. Signed-off-by: Larsen, Steffen <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes add a cuda_dev_kit feature check for detecting availability of a CUDA SDK. CUDA include path and library path can be controlled through the new CUDA_INCLUDE and CUDA_LIBS_DIR variables.