Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL][CUDA] Re-enable host-task-dependency test for CUDA #1064

Merged
merged 1 commit into from
Sep 6, 2022
Merged

[SYCL][CUDA] Re-enable host-task-dependency test for CUDA #1064

merged 1 commit into from
Sep 6, 2022

Conversation

pgorlani
Copy link

This patch re-enables a test that seems not failing anymore. The test has been modified for avoiding deprecation messages and output the content of buffers in case of error.

Related to: intel/llvm#8813

@pgorlani pgorlani requested a review from a team as a code owner June 22, 2022 12:50
@pgorlani pgorlani requested a review from v-klochkov June 22, 2022 12:50
@pgorlani
Copy link
Author

Is it possible to have CI logs? If I click on Details I get 'server not found'.

v-klochkov
v-klochkov previously approved these changes Jun 22, 2022
View reviewed changes
@pgorlani
Copy link
Author

Hi @v-klochkov, is it possible to merge this?

@AerialMantis
Copy link

/verify

@AerialMantis
Copy link

AerialMantis commented Aug 8, 2022 •
edited
Loading

@bader @v-klochkov we think these test failures may have been a fluke, I tried to re-run them but it doesn't seem to have worked (maybe I'm doing it wrong), if these tests pass, are you happy for this to be merged, or is there any further reviews which I should request?

@AerialMantis
Copy link

@bader @v-klochkov friendly ping on this, could we re-run the CI for this?

@bader
Copy link

bader commented Sep 6, 2022

I suggest we merge tip of the intel branch to this PR and this will trigger another pre-commit run in CI. @AerialMantis, will this work for you?

@pgorlani
[SYCL][CUDA] Re-enable host-task-dependency test for CUDA
8942b7a 
This patch re-enables a test that seems not failing anymore.
The test has been modified for avoiding deprecation messages
and output the content of buffers in case of error.
@pgorlani pgorlani force-pushed the re-enable-host-task-dependency branch from 7be167b to 8942b7a Compare September 6, 2022 13:28
@pgorlani
Copy link
Author

pgorlani commented Sep 6, 2022 •
edited
Loading

The failures in Windows seem not related to this test. I.e.,

[2022-09-06T13:55:59.997Z] PASS: SYCL :: Basic/host-task-dependency.cpp (163 of 909)
[2022-09-06T14:17:42.360Z] UNSUPPORTED: SYCL :: Basic/host-task-dependency.cpp (157 of 909)

@bader bader merged commit 2eb7ff3 into intel:intel Sep 6, 2022
@bader
Copy link

bader commented Sep 6, 2022

I merged this pull request, but I'd like to note that existing checks to not cover CUDA devices.
Please, keep an eye on host-task-dependency status in pre-commit checks in intel/llvm repository.

@AerialMantis AerialMantis mentioned this pull request Nov 2, 2022
Closed
myler pushed a commit to myler/llvm-test-suite that referenced this pull request Mar 22, 2023
@pgorlani @bb-sycl
[SYCL][CUDA] Re-enable host-task-dependency test for CUDA (intel#1064)
29d27ef 
This patch re-enables a test that seems not failing anymore.
The test has been modified for avoiding deprecation messages
and output the content of buffers in case of error.
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
@pgorlani
[SYCL][CUDA] Re-enable host-task-dependency test for CUDA (intel/llvm…
256c3a5 
…-test-suite#1064)

This patch re-enables a test that seems not failing anymore.
The test has been modified for avoiding deprecation messages
and output the content of buffers in case of error.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@v-klochkov v-klochkov v-klochkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pgorlani @AerialMantis @bader @v-klochkov