[ESIMD] Added test to verify automatic conversion to stateless memory… #1104
Conversation
SYCL/ESIMD/force_stateless_mem.cpp
Outdated
| //===----------------------------------------------------------------------===// | ||
| // REQUIRES: gpu | ||
| // UNSUPPORTED: cuda || hip | ||
| // RUN: %clangxx -fsycl -fsycl-esimd-force-stateless-mem %s -o %t.out |
There was a problem hiding this comment.
For better coverage, my suggestion would be adding compilation with -fsycl-esimd-force-stateless-mem to all existing accessor-based tests. I.e. all of them would contain:
// RUN: %clangxx -fsycl %s -o %t.out
// RUN: %clangxx -fsycl -fsycl-esimd-force-stateless-mem %s -o %t_stateless.out
...
// RUN: %GPU_RUN_PLACEHOLDER %t.out
// RUN: %GPU_RUN_PLACEHOLDER %t_stateless.out
The same could be done for this test.
Does this make sense?
There was a problem hiding this comment.
@kbobrovs - thank you for the comment. I re-worked the PR. Now it splits existing tests using accessor-based API to pairs of tests: the standard-accessor-based and accessor-based-converted-to-stateless.
That is done to avoid having tests in CI that compile/run for too long.
Please review the tests.
v-klochkov
force-pushed
the
esimd_stateless_e2e
branch
from
b808e1f to
b75c5d8
Compare
This option automatically converts accessor-based memory accesses to stateless accesses. Signed-off-by: Vyacheslav N Klochkov <[email protected]>
Signed-off-by: Vyacheslav N Klochkov <[email protected]>
|
The only failed test is SYCL/Basic/enqueue_barrier.cpp. It is unrelated to this PR and we already have an internal tracker for it. |
* [ESIMD] Add LIT tests for -fsycl-esimd-force-stateless-mem This option automatically converts accessor-based memory accesses to stateless accesses. Signed-off-by: Vyacheslav N Klochkov <[email protected]>
…m-test-suite#1104) * [ESIMD] Add LIT tests for -fsycl-esimd-force-stateless-mem This option automatically converts accessor-based memory accesses to stateless accesses. Signed-off-by: Vyacheslav N Klochkov <[email protected]>
… access
The option -fsycl-esimd-force-stateless-mem automatically converts accessor
based intrinsics to their versions accepting pointers. This test verifies
gather, scatter, gather_rgba, scatter_rgba, scalar_load, scalar_store,
copy_from, copy_to.
Signed-off-by: Vyacheslav N Klochkov [email protected]