This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[ESIMD] Add a test specialization constant that is set but not used #1108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v-klochkov
force-pushed
the
esimd_dead_arg_elimination
branch
2 times, most recently
from
aa423c8 to
3b5e140
Compare
v-klochkov
changed the title
The test verifies that SegFault is not happening on the host side due to attempt to dereference the pointer to non-existing buffer that is supposed to be used for spec constants, but not allocated in the binary image when spec const is not used. Signed-off-by: Vyacheslav N Klochkov <[email protected]>
v-klochkov
force-pushed
the
esimd_dead_arg_elimination
branch
from
3b5e140 to
ab27103
Compare
|
This test verifies the fix merged here: intel/llvm#6464 |
fineg74
previously approved these changes
Jul 26, 2022
kbobrovs
reviewed
Jul 27, 2022
SYCL/ESIMD/unused_spec_const.cpp
Outdated
| // eliminated by DAE optimization OR nullptr is passed for that argument. | ||
|
|
||
| // KH.get_specialization_constant<Spec>(); | ||
| *A += 2; |
There was a problem hiding this comment.
formally speaking, we don't support C++ style memory operations in ESIMD (even though they sometimes work)
There was a problem hiding this comment.
Thank you. I replaced it with ESIMD load/store: 30ab516
Signed-off-by: Vyacheslav N Klochkov <[email protected]>
kbobrovs
approved these changes
Jul 27, 2022
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
…ntel#1108) * [ESIMD] Add a test for specialization const that is set but not used The test verifies that SegFault is not happening on the host side due to attempt to dereference the pointer to non-existing buffer that is supposed to be used for spec constants, but not allocated in the binary image when spec const is not used. Signed-off-by: Vyacheslav N Klochkov <[email protected]>
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…ntel/llvm-test-suite#1108) * [ESIMD] Add a test for specialization const that is set but not used The test verifies that SegFault is not happening on the host side due to attempt to dereference the pointer to non-existing buffer that is supposed to be used for spec constants, but not allocated in the binary image when spec const is not used. Signed-off-by: Vyacheslav N Klochkov <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vyacheslav N Klochkov [email protected]