Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL] Update invoke_simd smoke test, add test on argument conversion. #1146

Merged
merged 2 commits into from
Aug 16, 2022

Conversation

kbobrovs
Copy link

@kbobrovs kbobrovs commented Aug 14, 2022

invoke_simd_smoke.cpp is updated due to compiler changes.
[[intel::device_indirectly_callable]] attribute is now required for
user functions which are invoke_simd call targets.

Complementary change for intel/llvm#6544.

Signed-off-by: Konstantin S Bobrovsky [email protected]

@kbobrovs kbobrovs requested a review from a team as a code owner August 14, 2022 00:10
@kbobrovs kbobrovs requested a review from steffenlarsen August 14, 2022 00:10
invoke_simd_smoke.cpp is updated due to compiler changes.
[[intel::device_indirectly_callable]] attribute is now required for
user functions which are invoke_simd call targets.

Signed-off-by: Konstantin S Bobrovsky <[email protected]>
steffenlarsen
steffenlarsen previously approved these changes Aug 15, 2022
Copy link

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Only a small comment.

@kbobrovs
Copy link
Author

/verify with intel/llvm#6544

@kbobrovs
Copy link
Author

Failures are unrelated:

Jenkins/llvm-test-suite:
[2022-08-16T00:48:58.709Z] Unexpectedly Passed Tests (2):
[2022-08-16T00:48:58.709Z] SYCL :: SubGroup/reduce_spirv13.cpp
[2022-08-16T00:48:58.709Z] SYCL :: SubGroup/reduce_spirv13_fp64.cpp

Failures are expected and fixed by the compiler patch:
Jenkins/pre-ci-linux:
[2022-08-15T20:25:30.587Z] Failed Tests (1):
[2022-08-15T20:25:30.587Z] SYCL :: InvokeSimd/invoke_simd_conv.cpp

@kbobrovs kbobrovs merged commit 313c5bd into intel:intel Aug 16, 2022
myler pushed a commit to myler/llvm-test-suite that referenced this pull request Mar 22, 2023
intel#1146)

* [SYCL] Update invoke_simd smoke test, add test on argument conversion.

invoke_simd_smoke.cpp is updated due to compiler changes.
[[intel::device_indirectly_callable]] attribute is now required for
user functions which are invoke_simd call targets.

Signed-off-by: Konstantin S Bobrovsky <[email protected]>
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
intel/llvm-test-suite#1146)

* [SYCL] Update invoke_simd smoke test, add test on argument conversion.

invoke_simd_smoke.cpp is updated due to compiler changes.
[[intel::device_indirectly_callable]] attribute is now required for
user functions which are invoke_simd call targets.

Signed-off-by: Konstantin S Bobrovsky <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants