-
Notifications
You must be signed in to change notification settings - Fork 130
[SYCL] Support query of free device memory extension #1162
Conversation
Signed-off-by: Sergey V Maslov <[email protected]>
/verify with intel/llvm#6604 |
Signed-off-by: Sergey V Maslov <[email protected]>
/verify with intel/llvm#6604 |
Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
/verify with intel/llvm#6604 |
/verify with intel/llvm#6604 |
/verify with intel/llvm#6604 |
Signed-off-by: Sergey V Maslov <[email protected]>
/verify with intel/llvm#6604 |
// The test is to check that the free device memory is reported be Level Zero | ||
// backend | ||
// | ||
// CHECK: Free device memory |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CHECK will pass only if ext_intel_device_info_free_memory is supported by the device. I think we expect the test to pass even if device doesn't support it. The only option I see is to remove this CHECK, I guess we don't have dynamic checks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But we expect that ALL Level Zero devices support this extension.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@againull : are you OK with the test? we need this to complete the new feature (the compiler fix was merged)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I am ok with the test, thanks for clarification.
E2E test for intel/llvm#6604
Signed-off-by: Sergey V Maslov [email protected]