Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL] Support query of free device memory extension #1162

Merged
merged 5 commits into from
Sep 6, 2022

Conversation

smaslov-intel
Copy link

E2E test for intel/llvm#6604
Signed-off-by: Sergey V Maslov [email protected]

@smaslov-intel smaslov-intel requested a review from a team as a code owner August 18, 2022 14:50
@smaslov-intel
Copy link
Author

/verify with intel/llvm#6604

Signed-off-by: Sergey V Maslov <[email protected]>
@smaslov-intel
Copy link
Author

/verify with intel/llvm#6604

Signed-off-by: Sergey V Maslov <[email protected]>
Signed-off-by: Sergey V Maslov <[email protected]>
@smaslov-intel
Copy link
Author

/verify with intel/llvm#6604

@smaslov-intel smaslov-intel requested a review from againull August 23, 2022 11:10
@smaslov-intel
Copy link
Author

/verify with intel/llvm#6604

@smaslov-intel
Copy link
Author

/verify with intel/llvm#6604

Signed-off-by: Sergey V Maslov <[email protected]>
@smaslov-intel
Copy link
Author

/verify with intel/llvm#6604

// The test is to check that the free device memory is reported be Level Zero
// backend
//
// CHECK: Free device memory

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CHECK will pass only if ext_intel_device_info_free_memory is supported by the device. I think we expect the test to pass even if device doesn't support it. The only option I see is to remove this CHECK, I guess we don't have dynamic checks.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But we expect that ALL Level Zero devices support this extension.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@againull : are you OK with the test? we need this to complete the new feature (the compiler fix was merged)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I am ok with the test, thanks for clarification.

@againull againull self-requested a review September 6, 2022 17:50
@againull againull merged commit d6e43f6 into intel:intel Sep 6, 2022
@smaslov-intel smaslov-intel deleted the freemem branch October 19, 2022 19:09
myler pushed a commit to myler/llvm-test-suite that referenced this pull request Mar 22, 2023
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants