This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[ESIMD] Add bfloat16 test cases. #1193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Konstantin S Bobrovsky <[email protected]>
Signed-off-by: Konstantin S Bobrovsky <[email protected]>
kbobrovs
changed the title
|
/verify with intel/llvm#6664 |
v-klochkov
reviewed
Sep 1, 2022
| passed &= test<float, 16>(signed_ops, q); | ||
| passed &= test<double, 16>(signed_ops, q); | ||
|
|
||
| #ifdef USE_BF16 |
There was a problem hiding this comment.
The obvious downside of this approach is the duplication of checks/tests.
I.e. on PVC the lines 178-184 started twice: 1st time as part of unary_ops_heavy.cpp test, and then (the same code + line 189) as part of unary_ops_heavy_pvc.cpp
There was a problem hiding this comment.
Right, good catch! I will add proper test selection.
v-klochkov
approved these changes
Sep 2, 2022
|
Linux all passed (Jenkins/pre-ci-linux did not refresh icon for some reason), Windows - usual fp64 related failures unrelated to this patch. Merging. |
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
* [ESIMD] Add bfloat16 test cases - binary ops, unary plus, memory access, taking a view.
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
* [ESIMD] Add bfloat16 test cases - binary ops, unary plus, memory access, taking a view.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complementary compiler patch: intel/llvm#6664
Signed-off-by: Konstantin S Bobrovsky [email protected]