This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Remove host run and dependencies from SYCL/Basic tests #1198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the host run and any assumptions and operations related to the host device from the tests in SYCL/Basic. Co-authored-by: Sachkov, Alexey <[email protected]> Signed-off-by: Larsen, Steffen <[email protected]>
againull
previously approved these changes
Sep 8, 2022
Signed-off-by: Larsen, Steffen <[email protected]>
|
subdevice.cpp and subsubdevice.cpp changes were moved to #1224 as they would otherwise use the host device for part of the check, causing them to fail. |
| @@ -20,11 +20,6 @@ int main() { | |||
| auto DeviceList = | |||
| sycl::device::get_devices(sycl::info::device_type::accelerator); | |||
|
|
|||
| // remove host device from the list | |||
There was a problem hiding this comment.
What a weird test: ask for accelerator devices and then remove host from them. I wonder why did the test expect host to even be in that list?
There was a problem hiding this comment.
That's a very good question. It may have been restricted later and whoever did that just forgot to remove the redundant filtering. Or maybe it was a copy-paste mistake.
AlexeySachkov
approved these changes
Sep 8, 2022
dm-vodopyanov
approved these changes
Sep 9, 2022
myler
added a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
CMPLRTST-17973: switch icx/icpx instead of dpcpp to run llvm_test_suite_sycl
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
…1198) This commit removes the host run and any assumptions and operations related to the host device from the tests in SYCL/Basic. Co-authored-by: Sachkov, Alexey <[email protected]> Signed-off-by: Larsen, Steffen <[email protected]>
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
…1198) This commit removes the host run and any assumptions and operations related to the host device from the tests in SYCL/Basic. Co-authored-by: Sachkov, Alexey <[email protected]> Signed-off-by: Larsen, Steffen <[email protected]>
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…llvm-test-suite#1198) This commit removes the host run and any assumptions and operations related to the host device from the tests in SYCL/Basic. Co-authored-by: Sachkov, Alexey <[email protected]> Signed-off-by: Larsen, Steffen <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the host run and any assumptions and operations related to the host device from the tests in SYCL/Basic.