Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL][ESIMD][EMU] Setting default platform for ESIMD_EMULATOR #1226

Merged
merged 2 commits into from
Sep 16, 2022

Conversation

dongkyunahn-intel
Copy link

  • CM_EMU library package is recently updated to support multiple
    targets. This fix is to avoid target platform setting failure

- CM_EMU library package is recently updated to support multiple
targets. This fix is to avoid target platform setting failure
SYCL/lit.cfg.py Outdated
@@ -368,6 +368,8 @@
if lit_config.params.get('ze_debug'):
gpu_run_substitute = " env ZE_DEBUG={ZE_DEBUG} SYCL_DEVICE_FILTER=level_zero:gpu,host ".format(ZE_DEBUG=config.ze_debug)
config.available_features.add('ze_debug'+config.ze_debug)
elif config.sycl_be == "ext_intel_esimd_emulator":
gpu_run_substitute += "CM_RT_PLATFORM=skl "
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add comments what this setting means - CM_RT_PLATFORM=skl

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@dongkyunahn-intel
Copy link
Author

CM_EMU requires environment variable setup for CM_RT_PLATFORM. There was a bug in CM_EMU that allows kernel execution without the environment variable setup and it was fixed recently.

https://github.com/intel/cm-cpu-emulation/blob/master/README_CONFIG.md#hw-configuration-choice

@dongkyunahn-intel
Copy link
Author

Failures are only on Windows - not related to this patch.

@v-klochkov v-klochkov merged commit 76ab40d into intel:intel Sep 16, 2022
myler pushed a commit to myler/llvm-test-suite that referenced this pull request Mar 22, 2023
* [SYCL][ESIMD][EMU] Setting default platform for ESIMD_EMULATOR

- CM_EMU library package is recently updated to support multiple
targets. This fix is to avoid target platform setting failure
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
…m-test-suite#1226)

* [SYCL][ESIMD][EMU] Setting default platform for ESIMD_EMULATOR

- CM_EMU library package is recently updated to support multiple
targets. This fix is to avoid target platform setting failure
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants