This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Prevent skipped GPU run from overwriting CPU output in DeviceLib/assert.cpp #1228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ib/assert.cpp Though the two potential runs in DeviceLib/assert.cpp are mutually exclusive, skipping the latter run (GPU) will still trigger a write to the output file, overwriting the results from the previous (CPU) run. To avoid this, these changes first ensures the output file is cleared then makes the runs append their output to the file. Since the runs are mutually exclusive the file should at most contain the output of one expected run. Signed-off-by: Larsen, Steffen <[email protected]>
KornevNikita
approved these changes
Sep 5, 2022
AlexeySachkov
approved these changes
Sep 5, 2022
sergey-semenov
approved these changes
Sep 6, 2022
dm-vodopyanov
approved these changes
Sep 6, 2022
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
…ib/assert.cpp (intel#1228) Though the two potential runs in DeviceLib/assert.cpp are mutually exclusive, skipping the latter run (GPU) will still trigger a write to the output file, overwriting the results from the previous (CPU) run. To avoid this, these changes first ensures the output file is cleared then makes the runs append their output to the file. Since the runs are mutually exclusive the file should at most contain the output of one expected run. Signed-off-by: Larsen, Steffen <[email protected]>
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
…M-device_global [CMPLRLLVM-40432] Cherry-pick branch to Disable device_global test compilation without device_image_scope
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…ib/assert.cpp (intel/llvm-test-suite#1228) Though the two potential runs in DeviceLib/assert.cpp are mutually exclusive, skipping the latter run (GPU) will still trigger a write to the output file, overwriting the results from the previous (CPU) run. To avoid this, these changes first ensures the output file is cleared then makes the runs append their output to the file. Since the runs are mutually exclusive the file should at most contain the output of one expected run. Signed-off-by: Larsen, Steffen <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Though the two potential runs in DeviceLib/assert.cpp are mutually exclusive, skipping the latter run (GPU) will still trigger a write
to the output file, overwriting the results from the previous (CPU) run. To avoid this, these changes first ensures the output file is cleared then makes the runs append their output to the file. Since the runs are mutually exclusive the file should at most contain the output of one expected run.