Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL] Make DeviceGlobal tests unsupported rather than xfail #1235

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions SYCL/DeviceGlobal/device_global_arrow.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@
// RUN: %GPU_RUN_PLACEHOLDER %t_dev_img_scope.out
// RUN: %ACC_RUN_PLACEHOLDER %t_dev_img_scope.out
//
// Currently fails for CPUs due to missing support for the SPIR-V extension.
// Currently crashes on accelerators.
// XFAIL: cpu, accelerator
// CPU and accelerators are not currently guaranteed to support the required
// extensions they are disabled until they are.
// UNSUPPORTED: cpu, accelerator
//
// Tests operator-> on device_global.
// NOTE: USE_DEVICE_IMAGE_SCOPE needs both kernels to be in the same image so
Expand Down
6 changes: 3 additions & 3 deletions SYCL/DeviceGlobal/device_global_device_only.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@
// RUN: %GPU_RUN_PLACEHOLDER %t_dev_img_scope.out
// RUN: %ACC_RUN_PLACEHOLDER %t_dev_img_scope.out
//
// Currently fails for CPUs due to missing support for the SPIR-V extension.
// Currently crashes on accelerators.
// XFAIL: cpu, accelerator
// CPU and accelerators are not currently guaranteed to support the required
// extensions they are disabled until they are.
// UNSUPPORTED: cpu, accelerator
//
// Tests basic device_global access through device kernels.
// NOTE: USE_DEVICE_IMAGE_SCOPE needs both kernels to be in the same image so
Expand Down
6 changes: 3 additions & 3 deletions SYCL/DeviceGlobal/device_global_operator_passthrough.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@
// RUN: %GPU_RUN_PLACEHOLDER %t_dev_img_scope.out
// RUN: %ACC_RUN_PLACEHOLDER %t_dev_img_scope.out
//
// Currently fails for CPUs due to missing support for the SPIR-V extension.
// Currently crashes on accelerators.
// XFAIL: cpu, accelerator
// CPU and accelerators are not currently guaranteed to support the required
// extensions they are disabled until they are.
// UNSUPPORTED: cpu, accelerator
//
// Tests the passthrough of operators on device_global.
// NOTE: USE_DEVICE_IMAGE_SCOPE needs both kernels to be in the same image so
Expand Down
6 changes: 3 additions & 3 deletions SYCL/DeviceGlobal/device_global_subscript.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,9 @@
// RUN: %GPU_RUN_PLACEHOLDER %t_dev_img_scope.out
// RUN: %ACC_RUN_PLACEHOLDER %t_dev_img_scope.out
//
// Currently fails for CPUs due to missing support for the SPIR-V extension.
// Currently crashes on accelerators.
// XFAIL: cpu, accelerator
// CPU and accelerators are not currently guaranteed to support the required
// extensions they are disabled until they are.
// UNSUPPORTED: cpu, accelerator
//
// Tests operator[] on device_global.
// NOTE: USE_DEVICE_IMAGE_SCOPE needs both kernels to be in the same image so
Expand Down