This repository was archived by the owner on Mar 28, 2023. It is now read-only.
Update SubGroup tests to account for optionality of double #1241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: I haven't updated |
steffenlarsen
approved these changes
Sep 9, 2022
aelovikov-intel
approved these changes
Sep 9, 2022
Comment on lines
+19
to
+25
| if (Queue.get_device().has(sycl::aspect::fp64)) { | ||
| check<double>(Queue); | ||
| std::cout << "Test passed." << std::endl; | ||
| } else { | ||
| std::cout << "Test skipped because device doesn't support aspect::fp64" | ||
| << std::endl; | ||
| } |
There was a problem hiding this comment.
I'm not sure if I'm going to ask to do that as part of this PR, but the best way would be to merge all shuffle_*.cpp tests into one using this method.
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
While optional kernel features are not fully implemented yet, let's fallback to per-kernel device code split to avoid problem with speculative compilation of all kernels regardless of some of them using optional functionality unsupported by some devices.
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…m-test-suite#1241) While optional kernel features are not fully implemented yet, let's fallback to per-kernel device code split to avoid problem with speculative compilation of all kernels regardless of some of them using optional functionality unsupported by some devices.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While optional kernel features are not fully implemented yet, let's fallback to per-kernel device code split to avoid problem with speculative compilation of all kernels regardless of some of them using optional functionality unsupported by some devices.