Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

Add tests for trivial fp16 util functions. #1250

Merged
merged 5 commits into from
Nov 16, 2022

Conversation

jinge90
Copy link

@jinge90 jinge90 commented Sep 11, 2022

Signed-off-by: jinge90 [email protected]

@jinge90 jinge90 requested a review from a team as a code owner September 11, 2022 03:15
@jinge90 jinge90 marked this pull request as draft September 11, 2022 03:16
@jinge90
Copy link
Author

jinge90 commented Sep 11, 2022

This PR is test for intel/llvm#6691

@jinge90 jinge90 marked this pull request as ready for review September 16, 2022 07:14
@jinge90
Copy link
Author

jinge90 commented Sep 16, 2022

/verify with intel/llvm#6691

Copy link

@cperkinsintel cperkinsintel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jinge90
Copy link
Author

jinge90 commented Nov 9, 2022

Hi, @cperkinsintel
I updated the PR to add check for platform without fp16 support, could you help review again?
Thanks very much.

@jinge90 jinge90 requested a review from cperkinsintel November 9, 2022 13:11
@jinge90
Copy link
Author

jinge90 commented Nov 16, 2022

One test failed on Windows:
SYCL :: KernelAndProgram/kernel-bundle-merge-options-env.cpp
This failure should not be related to this PR.

Hi, @pvchupin
Could you help merge this PR?

Thanks very much.

@pvchupin pvchupin merged commit 508b946 into intel:intel Nov 16, 2022
myler pushed a commit to myler/llvm-test-suite that referenced this pull request Mar 22, 2023
* add tests for a bunch of fp16 utils
* add check for platform without fp16 support

Signed-off-by: jinge90 <[email protected]>
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
* add tests for a bunch of fp16 utils
* add check for platform without fp16 support

Signed-off-by: jinge90 <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants