Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL][L0] Fix has_aspect_atomic64 test and reenable it #1253

Merged

Conversation

KseniyaTikhomirova
Copy link

@KseniyaTikhomirova KseniyaTikhomirova commented Sep 12, 2022

zeDeviceGetModuleProperties parameter ze_device_module_properties_t is an in/out parameter. It has void *pNext field where you can attach extensions to be filled too. So we should initialize the structure to not confuse backend by trash in the pNext pointer field that may lead either to hang or seg fault.

Signed-off-by: Tikhomirova, Kseniya [email protected]

@KseniyaTikhomirova KseniyaTikhomirova marked this pull request as ready for review September 12, 2022 18:19
@KseniyaTikhomirova KseniyaTikhomirova requested a review from a team as a code owner September 12, 2022 18:19
@KseniyaTikhomirova
Copy link
Author

@dm-vodopyanov hello, could you please review?

@KseniyaTikhomirova
Copy link
Author

@intel/llvm-gatekeepers hello, failures are unrelated (I enabled test and it passed), could we merge it?

@steffenlarsen steffenlarsen merged commit 106dd60 into intel:intel Sep 14, 2022
myler pushed a commit to myler/llvm-test-suite that referenced this pull request Mar 22, 2023
Fix has_aspect_atomic64 test and reenable it

Signed-off-by: Tikhomirova, Kseniya <[email protected]>
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
…est-suite#1253)

Fix has_aspect_atomic64 test and reenable it

Signed-off-by: Tikhomirova, Kseniya <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants