This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Disable device_global test compilation without device_image_scope #1267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since device_global does not currently work without the device_image_scope an error has been added to prevent any use of it prior to proper support. This commit changes the device_global tests to avoid compiling device_global without the currently required property. Signed-off-by: Larsen, Steffen <[email protected]>
v-klochkov
approved these changes
Sep 15, 2022
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
…ope (intel#1267) Since device_global does not currently work without the device_image_scope an error has been added to prevent any use of it prior to proper support. This commit changes the device_global tests to avoid compiling device_global without the currently required property. Signed-off-by: Larsen, Steffen <[email protected]>
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…ope (intel/llvm-test-suite#1267) Since device_global does not currently work without the device_image_scope an error has been added to prevent any use of it prior to proper support. This commit changes the device_global tests to avoid compiling device_global without the currently required property. Signed-off-by: Larsen, Steffen <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since device_global does not currently work without the device_image_scope an error has been added to prevent any use of it prior to proper support. This commit changes the device_global tests to avoid compiling device_global without the currently required property.