Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

Add named_barriers tests #1272

Merged
merged 3 commits into from
Oct 13, 2022
Merged

Add named_barriers tests #1272

merged 3 commits into from
Oct 13, 2022

Conversation

fveselov
Copy link

Tests on named_barriers for PVC migrate from closed repo

@fveselov fveselov requested a review from a team as a code owner September 16, 2022 10:04
@kbobrovs
Copy link

@fveselov, sorry for delay. Did you run the tests on PVC?

@fveselov
Copy link
Author

@kbobrovs, yes.
There were some issues that didn't show up running on simulator, but they were fixed. Currently all tests pass on PVC-XT HW.

@kbobrovs kbobrovs merged commit 05700f0 into intel:intel Oct 13, 2022
pvchupin pushed a commit that referenced this pull request Oct 14, 2022
pvchupin pushed a commit that referenced this pull request Oct 14, 2022
Revert "Add named_barriers tests (#1272)"

This reverts commit 05700f0.
@pvchupin
Copy link

pvchupin commented Oct 14, 2022

Tests fail on esimd_emulator in unrelated pre-commit testing. Reverted.

@kbobrovs
Copy link

@fveselov, the patch was reverted because tests failed on emulator. Did you run them on emulator? Please remove "|| esimd_emulator" everywhere and add a TODO, and create a new PR
@dongkyunahn-intel, FYI

@kbobrovs kbobrovs mentioned this pull request Oct 14, 2022
@kbobrovs
Copy link

Replacement PR: #1326

myler pushed a commit to myler/llvm-test-suite that referenced this pull request Mar 22, 2023
myler pushed a commit to myler/llvm-test-suite that referenced this pull request Mar 22, 2023
Revert "Add named_barriers tests (intel#1272)"

This reverts commit 05700f0.
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants