This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL][ESIMD][EMU] LSC Atomic update for emulator backend #1274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Argument order fix for cmpxchg - Enabling lsc_fence.cpp test
|
Failures are only on Windows - not related to this patch. |
kbobrovs
reviewed
Sep 19, 2022
SYCL/ESIMD/lsc/Inputs/lsc_surf.hpp
Outdated
| @@ -75,8 +75,8 @@ int main() { | |||
| lsc_atomic_update<atomic_op::inc, int>(access_2, offsets, pred); | |||
| lsc_atomic_update<atomic_op::add, int>(access_3, offsets, add, | |||
| pred); | |||
| lsc_atomic_update<atomic_op::cmpxchg, int>(access_4, offsets, | |||
| compare, swap, pred); | |||
| lsc_atomic_update<atomic_op::cmpxchg, int>(access_4, offsets, swap, | |||
kbobrovs
reviewed
Sep 19, 2022
- Comparison value first, new value second
kbobrovs
approved these changes
Oct 14, 2022
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
* [SYCL][ESIMD][EMU] LSC Atomic update for emulator backend - Argument order fix for cmpxchg - Enabling lsc_fence.cpp test * UNSUPPORTED for esimd_emulator due to random timeout
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…-test-suite#1274) * [SYCL][ESIMD][EMU] LSC Atomic update for emulator backend - Argument order fix for cmpxchg - Enabling lsc_fence.cpp test * UNSUPPORTED for esimd_emulator due to random timeout
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complementary compiler patch: intel/llvm#6661