Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

Set the feature macro to use the non-use matrix API #1292

Merged
merged 1 commit into from
Sep 30, 2022

Conversation

dkhaldi
Copy link

@dkhaldi dkhaldi commented Sep 28, 2022

By default, a new API that has an extra "use" argument will be used.
So for the other tests that use the old API, the macro will have to be explicitly set

@dkhaldi dkhaldi requested a review from a team as a code owner September 28, 2022 13:49
Copy link

@aelovikov-intel aelovikov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a link to the functional change in this PR's conversation.

Copy link

@yubingex007-a11y yubingex007-a11y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dkhaldi
Copy link
Author

dkhaldi commented Sep 30, 2022

@aelovikov-intel, the fails are not related to this change?
Can we merge this PR?

@aelovikov-intel
Copy link

@aelovikov-intel, the fails are not related to this change? Can we merge this PR?

I don't have commit rights. @intel/llvm-gatekeepers are able to merge PRs.

@pvchupin
Copy link

Fails are probably related to #1289

@pvchupin pvchupin merged commit 25c9aad into intel:intel Sep 30, 2022
@dkhaldi dkhaldi deleted the fix-macro-value branch December 21, 2022 20:28
myler pushed a commit to myler/llvm-test-suite that referenced this pull request Mar 22, 2023
By default, a new API that has an extra "use" argument will be used.
So for the other tests that use the old API, the macro will have to be explicitly set
myler added a commit to myler/llvm-test-suite that referenced this pull request Mar 22, 2023
Cherry-pick "Remove host run and dependencies" to xmain
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
…m-test-suite#1292)

By default, a new API that has an extra "use" argument will be used.
So for the other tests that use the old API, the macro will have to be explicitly set
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants