[SYCL] update tests with changes in device selector exception message #1295
Conversation
|
/verify with intel/llvm#6896 |
|
/verify with intel/llvm#6896 |
1 similar comment
|
/verify with intel/llvm#6896 |
| @@ -0,0 +1,48 @@ | |||
| // RUN: %clangxx -fsycl -fsycl-targets=%sycl_triple %s -o %t.out | |||
| // RUN: %t.out | |||
There was a problem hiding this comment.
The simpler way to set env var:
| // RUN: %t.out | |
| // RUN: env SYCL_DEVICE_FILTER="" %t.out |
It doesn't require calling 'setenv()' and defining setenv() for _Win32.
E.g.: https://github.com/intel/llvm-test-suite/blob/intel/SYCL/FilterSelector/select_device.cpp#L3
There was a problem hiding this comment.
It interesting, that this test does not need any devices at all. And it is enough to run it once instead of running it with CPU, then with GPU, then with ACC, CUDA, etc.
If so, it is makes sense adding it right to the compiler: https://github.com/intel/llvm/tree/sycl/sycl/test
There was a problem hiding this comment.
Thank you! Updated. Do you think sycl/test/basic_tests is a good place for the new test?
There was a problem hiding this comment.
Yes, "sycl/test/basic_tests" seems good enough to me.
| // Disable all available devices | ||
| setenv("SYCL_DEVICE_FILTER", "", 0); | ||
|
|
There was a problem hiding this comment.
| // Disable all available devices | |
| setenv("SYCL_DEVICE_FILTER", "", 0); |
mkrainiuk
changed the title
|
/verify with intel/llvm#6896 |
|
/verify with intel/llvm#6896 |
[SYCL] Replace SYCL_EXT_ONEAPI_MATRIX with SYCL_EXT_ONEAPI_MATRIX_VERSION
Update tests with changes in device selector exception message intel/llvm#6896